linux-kernel - Re: [PATCH v3 0/4] Improve error handling for qnap-mcu transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176363370646.591986.11942329205687467723.b4-ty@kernel.org>
Date: Thu, 20 Nov 2025 10:15:06 +0000
From: Lee Jones <lee@...nel.org>
To: lee@...nel.org, Heiko Stuebner <heiko@...ech.de>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/4] Improve error handling for qnap-mcu transfers

On Thu, 13 Nov 2025 17:52:14 +0100, Heiko Stuebner wrote:
> Digging deeper into how that MCU behaves, I found out it can return
> more status codes than the "@0" for "ok".
> 
> The additional codes can report a failed checksum verification and
> some "general" error for the command execution.
> 
> This also explains sporadic command timeout messages, I have seen
> over time, when the controller sends an error code while we expect
> a longer reply from it.
> 
> [...]

Applied, thanks!

[1/4] mfd: qnap-mcu: Calculate the checksum on the actual number of bytes received
      commit: b4881070a02b017aea84592c424d5a980ed261c4
[2/4] mfd: qnap-mcu: Use EPROTO in stead of EIO on checksum errors
      commit: c94fce30e190555d74e2769b5fe4a932d0ad432e
[3/4] mfd: qnap-mcu: Move checksum verification to its own function
      commit: c3223f562586307b1bcb014475d0b71913972145
[4/4] mfd: qnap-mcu: Add proper error handling for command errors
      commit: 56c1245d51faab70bf68cc3a5cd3925768e6375b

--
Lee Jones [李琼斯]