linux-kernel - Re: [PATCH 0/3] Samsung mfd/rtc driver alarm IRQ simplification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ebfbfa9d592b7a5d965dadf5f3615a77c89cb03.camel@linaro.org>
Date: Thu, 20 Nov 2025 10:32:22 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Lee Jones <lee@...nel.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Alexandre Belloni	
 <alexandre.belloni@...tlin.com>, Peter Griffin <peter.griffin@...aro.org>, 
 Tudor Ambarus <tudor.ambarus@...aro.org>, Will McVicker
 <willmcvicker@...gle.com>, Juan Yescas	 <jyescas@...gle.com>, Douglas
 Anderson <dianders@...omium.org>, 	kernel-team@...roid.com, Kaustabh
 Chakraborty <kauschluss@...root.org>, 	linux-kernel@...r.kernel.org,
 linux-samsung-soc@...r.kernel.org, 	linux-rtc@...r.kernel.org
Subject: Re: [PATCH 0/3] Samsung mfd/rtc driver alarm IRQ simplification

Hi Lee,

On Thu, 2025-11-20 at 10:31 +0000, Lee Jones wrote:
> On Fri, 14 Nov 2025, André Draszik wrote:
> 
> > Hi,
> > 
> > With the attached patches the Samsung s5m RTC driver is simplified a
> > little bit with regards to alarm IRQ acquisition.
> > 
> > The end result is that instead of having a list of IRQ numbers for each
> > variant (and a BUILD_BUG_ON() to ensure consistency), the RTC driver
> > queries the 'alarm' platform resource from the parent (mfd cell).
> > 
> > Additionally, we can drop a now-useless field from runtime data,
> > reducing memory consumption slightly.
> > 
> > The attached patches must be applied in-order. I would expect them all
> > to go via the MFD tree. Alternatively, they could be applied one after
> > another during multiple kernel release cycles, but that seems a
> > needless complication.
> > 
> > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > ---
> > André Draszik (3):
> >       mfd: sec: add rtc alarm IRQ as platform device resource
> >       rtc: s5m: query platform device IRQ resource for alarm IRQ
> >       mfd: sec: drop now unused struct sec_pmic_dev::irq_data
> > 
> >  drivers/mfd/sec-common.c         | 41 ++++++++++++++++++++++++++++++----------
> >  drivers/mfd/sec-core.h           |  2 +-
> >  drivers/mfd/sec-irq.c            | 10 ++--------
> >  drivers/rtc/rtc-s5m.c            | 21 ++++++++------------
> >  include/linux/mfd/samsung/core.h |  1 -
> >  5 files changed, 42 insertions(+), 33 deletions(-)
> 
> This needs to be rebased now, right?

Yes, I'll do that now. Thanks for merging the other patch.


Cheers,
Andre'