linux-kernel - Re: [PATCH v2] staging: rtl8723bs: core: fix block comment style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR7Bu4ared9jg1ag@stanley.mountain>
Date: Thu, 20 Nov 2025 10:22:35 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Artur Stupa <arthur.stupa@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: core: fix block comment style
 issues

On Wed, Nov 19, 2025 at 04:29:21PM -0800, Artur Stupa wrote:
> +/*
> + **********************************************************************

I was going to ignore this ************** line, but

> + * Routine: Phase 1 -- generate P1K, given TA, TK, IV32
> + *
> + * Inputs:
> + *     tk[]      = temporal key                         [128 bits]
> + *     ta[]      = transmitter's MAC address            [ 48 bits]
> + *     iv32      = upper 32 bits of IV                  [ 32 bits]
> + * Output:
> + *     p1k[]     = Phase 1 key                          [ 80 bits]
> + *
> + * Note:
> + *     This function only needs to be called every 2**16 packets,
> + *     although in theory it could be called every packet.
> + *
> + **********************************************************************
> + */
>  static void phase1(u16 *p1k, const u8 *tk, const u8 *ta, u32 iv32)
>  {
>  	signed int  i;

[ snip ]

> diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> index d1f6030799cb..2014998245db 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> @@ -385,10 +385,10 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta)
>  	rtw_release_macid(pstapriv->padapter, psta);
>  
>  /*
> -	spin_lock_bh(&pstapriv->asoc_list_lock);
> -	list_del_init(&psta->asoc_list);
> -	spin_unlock_bh(&pstapriv->asoc_list_lock);
> -*/
> + * spin_lock_bh(&pstapriv->asoc_list_lock);
> + * list_del_init(&psta->asoc_list);
> + * spin_unlock_bh(&pstapriv->asoc_list_lock);
> + */

I had to complain about this.  Please, delete commented out code.

To be honest, it would be better to break this up into two patches, one
which deletes dead code and the other which changes the comment formats.
I wouldn't have said anything about that if it hadn't been for this
dead code.

regards,
dan carpenter