linux-kernel - Re: [PATCH v5 2/2] selftests/riscv: Add Zicbop prefetch test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120112351.34433-1-zihong.plct@isrc.iscas.ac.cn>
Date: Thu, 20 Nov 2025 19:23:50 +0800
From: Yao Zihong <zihong.plct@...c.iscas.ac.cn>
To: ajones@...tanamicro.com
Cc: alex@...ti.fr,
	alexghiti@...osinc.com,
	aou@...s.berkeley.edu,
	cleger@...osinc.com,
	cuiyunhui@...edance.com,
	evan@...osinc.com,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	palmer@...belt.com,
	pjw@...nel.org,
	samuel.holland@...ive.com,
	shuah@...nel.org,
	zhangyin2018@...as.ac.cn,
	zihong.plct@...c.iscas.ac.cn,
	zihongyao@...look.com
Subject: Re: [PATCH v5 2/2] selftests/riscv: Add Zicbop prefetch test

Hi Andrew,

On Tue, 18 Nov 2025 10:45:43 -0600, Andrew Jones wrote:
> I would have written it like below to avoid four redundant lines
> 
>  case 'm': case 'z':
>    tests[opt == 'm' ? TEST_NO_ZICBOM : TEST_NO_ZICBOZ].enabled = true;
>    tests[TEST_NO_CBO_INVAL].enabled = true;
>    rc = sigaction(SIGILL, &act, NULL);
>    assert(rc == 0);
>    break;

I'll apply this style pattern in future patches, or in a v6 if we end up
needing one.

Thanks,
Zihong