linux-kernel - Re: [PATCH v2] spi: cs42l43: Use actual ACPI firmware node for chip selects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3beb841e99f62767547054c4344f2c60eae4ed9b.camel@pengutronix.de>
Date: Thu, 20 Nov 2025 12:21:10 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>, broonie@...nel.org, 
	brgl@...ev.pl, linus.walleij@...aro.org
Cc: andy@...nel.org, linux-gpio@...r.kernel.org, linux-spi@...r.kernel.org, 
	bartosz.golaszewski@...aro.org, linux-kernel@...r.kernel.org, 
	patches@...nsource.cirrus.com
Subject: Re: [PATCH v2] spi: cs42l43: Use actual ACPI firmware node for chip
 selects

On Do, 2025-11-20 at 10:59 +0000, Charles Keepax wrote:
> On some systems the cs42l43 has amplifiers attached to its SPI
> controller that are not properly defined in ACPI. Currently
> software nodes are added to support this case, however, the chip
> selects for these devices are specified using a hack. A software
> node is added with the same name as the pinctrl driver, as the
> look up was name based, this allowed the GPIO look up to return
> the pinctrl driver even though the swnode was not owned by it.
> This was necessary as the swnodes did not support directly
> linking to real firmware nodes.
> 
> Since commit e5d527be7e69 ("gpio: swnode: don't use the swnode's
> name as the key for GPIO lookup") changed the lookup to be
> fwnode based this hack will no longer find the pinctrl driver,
> resulting in the driver not probing. There is no pinctrl driver
> attached to the swnode itself. But other patches did add support
> for linking a swnode to a real fwnode node [1]. As such the hack
> is no longer needed, so switch over to just passing the real
> fwnode for the pinctrl property to avoid any issues.
> 
> Link: https://lore.kernel.org/linux-gpio/20251106-reset-gpios-swnodes-v6-0-69aa852de9e4@linaro.org/ [1]
> Fixes: 439fbc97502a ("spi: cs42l43: Add bridged cs35l56 amplifiers")
> Fixes: e5d527be7e69 ("gpio: swnode: don't use the swnode's name as the key for GPIO lookup")
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> ---
> 
> IMPORTANT NOTE: This depends both functionally and build wise on the
> linked series from Bart, it probably makes sense for him to pull the
> patch into his series.

When included in the reset-gpios-swnodes series, will this need either
a noautosel or prerequisite marker to avoid it being picked up into
stable without the reset of the series?

regards
Philipp