linux-kernel - Re: [PATCH -next] coresight: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30c078df-82ff-4914-b5a2-58cb2d6dd073@linaro.org>
Date: Thu, 20 Nov 2025 11:23:55 +0000
From: James Clark <james.clark@...aro.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, suzuki.poulose@....com
Cc: mike.leach@...aro.org, alexander.shishkin@...ux.intel.com,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] coresight: remove unneeded semicolon



On 20/11/2025 9:41 am, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./drivers/hwtracing/coresight/coresight-priv.h:238:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27327
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/hwtracing/coresight/coresight-priv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
> index fd896ac07942..16f0cee8cad6 100644
> --- a/drivers/hwtracing/coresight/coresight-priv.h
> +++ b/drivers/hwtracing/coresight/coresight-priv.h
> @@ -235,7 +235,7 @@ static inline void *coresight_get_uci_data_from_amba(const struct amba_id *table
>   		if ((pid & table->mask) == table->id)
>   			return coresight_get_uci_data(table);
>   		table++;
> -	};
> +	}
>   	return NULL;
>   }
>   

Reviewed-by: James Clark <james.clark@...aro.org>

I turned on -Wextra-semi-stmt for Coresight but it results in hundreds 
warnings because of the way macros like wmb() are always used with a 
semicolon.

So I'm not really sure what the point of fixing these up is? Because 
they can never all be fixed without a fundamental style change so why 
not just ignore them?

James