linux-kernel - Re: [PATCH] rust: slice: fix broken intra-doc links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DED5D81TXPCO.3FK81IGE9KR0O@nvidia.com>
Date: Thu, 20 Nov 2025 10:56:29 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Miguel Ojeda" <ojeda@...nel.org>, "Alexandre Courbot"
 <acourbot@...dia.com>, "Danilo Krummrich" <dakr@...nel.org>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "Alex Gaynor" <alex.gaynor@...il.com>
Cc: "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Trevor
 Gross" <tmgross@...ch.edu>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>
Subject: Re: [PATCH] rust: slice: fix broken intra-doc links

On Thu Nov 20, 2025 at 3:51 AM JST, Miguel Ojeda wrote:
> In older versions of Rust, the compiler doesn't know about the newer
> `as_flattened*` methods, thus `rustdoc` complains about the intra-doc
> links, e.g.
>
>      error: unresolved link to `slice::as_flattened`
>       --> rust/kernel/slice.rs:19:23
>        |
>     19 | /// [`as_flattened`]: slice::as_flattened
>        |                       ^^^^^^^^^^^^^^^^^^^ the primitive type `slice` has no associated item named `as_flattened`
>        |
>        = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
>        = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`
>
> Thus fix them by using an URL instead.
>
> Fixes: 88622323dde3 ("rust: enable slice_flatten feature and provide it through an extension trait")
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> ---
> I have seen this in -next -- please feel free to take it or rebase if
> preferred etc., of course. Thanks!

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

Alice, I guess we will want to take this into drm-rust-next or
drm-rust-fixes since that's where the patch introducing this originates
from?