linux-kernel - Re: [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add prefix for XuanTie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251121-shortlist-coroner-b29e19293b40@spud>
Date: Fri, 21 Nov 2025 12:30:54 +0000
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: cp0613@...ux.alibaba.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, pjw@...nel.org, palmer@...belt.com,
	aou@...s.berkeley.edu, peterz@...radead.org, mingo@...hat.com,
	acme@...nel.org, namhyung@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com, james.clark@...aro.org,
	guoren@...nel.org, devicetree@...r.kernel.org,
	linux-perf-users@...r.kernel.org, linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add prefix for
 XuanTie

On Fri, Nov 21, 2025 at 10:01:07AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 21, 2025 at 02:34:36PM +0800, cp0613@...ux.alibaba.com wrote:
> > From: Chen Pei <cp0613@...ux.alibaba.com>
> > 
> > Add new vendor strings to dt bindings for RISC-V vendor XuanTie.
> > 
> > Signed-off-by: Chen Pei <cp0613@...ux.alibaba.com>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index f1d1882009ba..5d28b2da94cd 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -1829,6 +1829,8 @@ patternProperties:
> >      description: Xilinx
> >    "^xnano,.*":
> >      description: Xnano
> > +  "^xuantie,.*":
> > +    description: C-SKY Microsystems Co., Ltd. (XuanTie)
> 
> We do not create new prefixes for existing entries. You have already
> csky, alibaba and thead and probably many more. Choose some appropriate.

When the vendor literally says "C-SKY", it's hard to buy why csky
shouldn't be used here. Xuantie is described as being a brand, where at
least t-head was a company. This seems akin to having
"snapdragon,msm8660" instead of "qcom,msm8660", for example.

> 
> Your commit msg should also explain anything unusual here, like above.
> 
> Best regards,
> Krzysztof
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)