linux-kernel - Re: [PATCH] net: wwan: t7xx: Make local function static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFEp6-338P9-xvKaJdwoZx1bGM3OyiZG=E+tjOdO_poh1rjsfw@mail.gmail.com>
Date: Fri, 21 Nov 2025 13:53:32 +0100
From: Loic Poulain <loic.poulain@....qualcomm.com>
To: Slark Xiao <slark_xiao@....com>
Cc: chandrashekar.devegowda@...el.com, chiranjeevi.rapolu@...ux.intel.com,
        haijun.liu@...iatek.com, ryazanov.s.a@...il.com,
        johannes@...solutions.net, andrew+netdev@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wwan: t7xx: Make local function static

On Thu, Nov 20, 2025 at 12:53 PM Slark Xiao <slark_xiao@....com> wrote:
>
> This function was used in t7xx_hif_cldma.c only. Make it static
> as it should be.
>
> Signed-off-by: Slark Xiao <slark_xiao@....com>

I believe it would be best to target net-next for this change.

Reviewed-by: Loic Poulain <loic.poulain@...lcomm.com>

> ---
>  drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 2 +-
>  drivers/net/wwan/t7xx/t7xx_hif_cldma.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wwan/t7xx/t7xx_hif_cldma.c b/drivers/net/wwan/t7xx/t7xx_hif_cldma.c
> index 97163e1e5783..bd16788882f0 100644
> --- a/drivers/net/wwan/t7xx/t7xx_hif_cldma.c
> +++ b/drivers/net/wwan/t7xx/t7xx_hif_cldma.c
> @@ -899,7 +899,7 @@ static void t7xx_cldma_hw_start_send(struct cldma_ctrl *md_ctrl, int qno,
>   * @queue: CLDMA queue.
>   * @recv_skb: Receiving skb callback.
>   */
> -void t7xx_cldma_set_recv_skb(struct cldma_queue *queue,
> +static void t7xx_cldma_set_recv_skb(struct cldma_queue *queue,
>                              int (*recv_skb)(struct cldma_queue *queue, struct sk_buff *skb))
>  {
>         queue->recv_skb = recv_skb;
> diff --git a/drivers/net/wwan/t7xx/t7xx_hif_cldma.h b/drivers/net/wwan/t7xx/t7xx_hif_cldma.h
> index f2d9941be9c8..9d0107e18a7b 100644
> --- a/drivers/net/wwan/t7xx/t7xx_hif_cldma.h
> +++ b/drivers/net/wwan/t7xx/t7xx_hif_cldma.h
> @@ -126,8 +126,6 @@ void t7xx_cldma_switch_cfg(struct cldma_ctrl *md_ctrl, enum cldma_cfg cfg_id);
>  void t7xx_cldma_start(struct cldma_ctrl *md_ctrl);
>  int t7xx_cldma_stop(struct cldma_ctrl *md_ctrl);
>  void t7xx_cldma_reset(struct cldma_ctrl *md_ctrl);
> -void t7xx_cldma_set_recv_skb(struct cldma_queue *queue,
> -                            int (*recv_skb)(struct cldma_queue *queue, struct sk_buff *skb));
>  int t7xx_cldma_send_skb(struct cldma_ctrl *md_ctrl, int qno, struct sk_buff *skb);
>  void t7xx_cldma_stop_all_qs(struct cldma_ctrl *md_ctrl, enum mtk_txrx tx_rx);
>  void t7xx_cldma_clear_all_qs(struct cldma_ctrl *md_ctrl, enum mtk_txrx tx_rx);
> --
> 2.25.1
>