linux-kernel - [PATCH next] memory: tegra210-emc: Fix error codes in tegra210_emc_opp_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aSBqyISKPN5TWbGu@stanley.mountain>
Date: Fri, 21 Nov 2025 16:36:08 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Aaron Kling <webgeek1234@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [PATCH next] memory: tegra210-emc: Fix error codes in
 tegra210_emc_opp_table_init()

Fix several error paths where the error code was not set correctly.

Fixes: b33c93babead ("memory: tegra210: Support interconnect framework")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
 drivers/memory/tegra/tegra210-emc-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 397448cb472d..c97ce799d53d 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -1981,11 +1981,13 @@ static int tegra210_emc_opp_table_init(struct tegra210_emc *emc)
 
 	max_opps = dev_pm_opp_get_opp_count(emc->dev);
 	if (max_opps <= 0) {
+		err = max_opps ?: -EINVAL;
 		dev_err_probe(emc->dev, err, "Failed to add OPPs\n");
 		goto remove_table;
 	}
 
 	if (emc->num_timings != max_opps) {
+		err = -EINVAL;
 		dev_err_probe(emc->dev, err, "OPP table does not match emc table\n");
 		goto remove_table;
 	}
@@ -1994,6 +1996,7 @@ static int tegra210_emc_opp_table_init(struct tegra210_emc *emc)
 		rate = emc->timings[i].rate * 1000;
 		opp = dev_pm_opp_find_freq_exact(emc->dev, rate, true);
 		if (IS_ERR(opp)) {
+			err = PTR_ERR(opp);
 			dev_err_probe(emc->dev, err, "Rate %lu not found in OPP table\n", rate);
 			goto remove_table;
 		}
-- 
2.51.0