linux-kernel - Re: [PATCH] platform/x86: intel: chtwc_int33fe: don't dereference swnode args

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdSai2EaQfAqjxdmLBdXPQVc8s4b5_sKDmuZV8gBCKp4g@mail.gmail.com>
Date: Fri, 21 Nov 2025 14:50:17 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Charles Keepax <ckeepax@...nsource.cirrus.com>, 
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, stable@...r.kernel.org, 
	Hans de Goede <hansg@...nel.org>, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] platform/x86: intel: chtwc_int33fe: don't dereference
 swnode args

On Fri, Nov 21, 2025 at 2:40 PM Hans de Goede <hansg@...nel.org> wrote:
>
> On 21-Nov-25 11:04 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Members of struct software_node_ref_args should not be dereferenced
> > directly but set using the provided macros. Commit d7cdbbc93c56
> > ("software node: allow referencing firmware nodes") changed the name of
> > the software node member and caused a build failure. Remove all direct
> > dereferences of the ref struct as a fix.
> >
> > However, this driver also seems to abuse the software node interface by
> > waiting for a node with an arbitrary name "intel-xhci-usb-sw" to appear
> > in the system before setting up the reference for the I2C device, while
> > the actual software node already exists in the intel-xhci-usb-role-switch
> > module and should be used to set up a static reference. Add a FIXME for
> > a future improvement.
> >
> > Fixes: d7cdbbc93c56 ("software node: allow referencing firmware nodes")
> > Fixes: 53c24c2932e5 ("platform/x86: intel_cht_int33fe: use inline reference properties")
> > Cc: stable@...r.kernel.org
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Closes: https://lore.kernel.org/all/20251121111534.7cdbfe5c@canb.auug.org.au/
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> > This should go into the reset tree as a fix to the regression introduced
> > by the reset-gpio driver rework.
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <johannes.goede@....qualcomm.com>
>
> Also ack for merging this through the reset tree.
>
> Ilpo please do *not* pick this one up as it will be merged
> through the reset tree.
>

Philipp: I'm afraid this too must go into an immutable branch shared
with the GPIO tree or else Linus Torvalds will yell at me if by chance
he pulls my changes first into mainline. Unless you plan to do your PR
early into the merge window in which case I can wait until it's in his
tree and submit mine. Let me know what your preference is.

Bart