linux-kernel - Re: [PATCH] soc: qcom: smem: fix qcom_smem_is_available and check if _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e79b63b-82c4-4e20-872e-1dfc1c1139a9@oss.qualcomm.com>
Date: Fri, 21 Nov 2025 14:51:11 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Christian Marangi <ansuelsmth@...il.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc: Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] soc: qcom: smem: fix qcom_smem_is_available and check if
 __smem is valid

On 11/21/25 10:11 AM, Christian Marangi wrote:
> Commit 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized
> state") changed the usage of __smem and init now as an error pointer
> instead of NULL.
> 
> qcom_smem_is_available() wasn't updated to reflect this change and also
> .qcom_smem_remove doesn't reset it on module exit.
> 
> While at it also proced other expoert symbol if __smem is not set to a
> correct pointer.

I think that's a separate issue where we should inspect the impact
(or just mention "please call qcom_smem_is_available() first, probably)

Konrad