linux-kernel - Re: [PATCH v5 2/2] s390/pci: Migrate s390 IRQ logic to IRQ domain API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEEFSYEK2EPX.7THCTOCXJLUU@linux.ibm.com>
Date: Fri, 21 Nov 2025 15:19:53 +0100
From: "Tobias Schumacher" <ts@...ux.ibm.com>
To: "Heiko Carstens" <hca@...ux.ibm.com>, "Gerd Bayer"
 <gbayer@...ux.ibm.com>
Cc: "Tobias Schumacher" <ts@...ux.ibm.com>,
        "Vasily Gorbik"
 <gor@...ux.ibm.com>,
        "Alexander Gordeev" <agordeev@...ux.ibm.com>,
        "Christian Borntraeger" <borntraeger@...ux.ibm.com>,
        "Sven Schnelle"
 <svens@...ux.ibm.com>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "Gerald
 Schaefer" <gerald.schaefer@...ux.ibm.com>,
        "Halil Pasic"
 <pasic@...ux.ibm.com>,
        "Matthew Rosato" <mjrosato@...ux.ibm.com>,
        "Thomas
 Gleixner" <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>, <linux-s390@...r.kernel.org>,
        "Farhan Ali" <alifm@...ux.ibm.com>
Subject: Re: [PATCH v5 2/2] s390/pci: Migrate s390 IRQ logic to IRQ domain
 API

On Fri Nov 21, 2025 at 3:03 PM CET, Heiko Carstens wrote:
> On Fri, Nov 21, 2025 at 02:27:38PM +0100, Gerd Bayer wrote:
>> >  	bus = pci_create_root_bus(NULL, ZPCI_BUS_NR, ops, zbus, &zbus->resources);
>> > -	if (!bus) {
>> > -		zpci_free_domain(zbus->domain_nr);
>> > -		return -EFAULT;
>> > -	}
>> > +	if (!bus)
>> > +		goto out_remove_msi_domain;
>> 
>> Or do you want to set rc to -EFAULT here, and return the "original" rc
>> in the error exits?
>> 
>> >  
>> >  	zbus->bus = bus;
>> > +	dev_set_msi_domain(&zbus->bus->dev, zbus->msi_parent_domain);
>> >  
>> >  	return 0;
>> > +
>> > +out_remove_msi_domain:
>> > +	zpci_remove_parent_msi_domain(zbus);
>> > +out_free_domain:
>> > +	zpci_free_domain(zbus->domain_nr);
>> > +	return -EFAULT;
>> >  }
>
> Oh, just realized this oddity with Gerd's reply: -EFAULT should _only_ be used
> for page faults. Looks like this return code is not passed to user space, but
> please change this to something more appropriate. E.g. -ENOMEM, or whatever
> fits here.
>
> Given that Gerd had quite a few more comments, please send a new version with
> my comments also addressed :)

Sure, will do

Thanks,
Tobias