linux-kernel - Re: [PATCH v4] drm/bridge: sii902x: Fix HDMI detection with DRM_BRIDGE_ATTACH_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176373739119.405542.6739584381002284376.b4-ty@linaro.org>
Date: Fri, 21 Nov 2025 16:03:11 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: andrzej.hajda@...el.com, rfoss@...nel.org, airlied@...il.com, 
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
 dri-devel@...ts.freedesktop.org, jani.nikula@...el.com, simona@...ll.ch, 
 linux-kernel@...r.kernel.org, Devarsh Thakkar <devarsht@...com>
Cc: tomi.valkeinen@...asonboard.com, praneeth@...com, vigneshr@...com, 
 aradhya.bhatia@...ux.dev, s-jain1@...com, s-wang12@...com, 
 r-donadkar@...com, h-shenoy@...com, dmitry.baryshkov@....qualcomm.com
Subject: Re: [PATCH v4] drm/bridge: sii902x: Fix HDMI detection with
 DRM_BRIDGE_ATTACH_NO_CONNECTOR

Hi,

On Thu, 30 Oct 2025 20:46:35 +0530, Devarsh Thakkar wrote:
> The sii902x driver was caching HDMI detection state in a sink_is_hdmi field
> and checking it in mode_set() to determine whether to set HDMI or DVI
> output mode. This approach had two problems:
> 
> 1. With DRM_BRIDGE_ATTACH_NO_CONNECTOR (used by modern display drivers like
> TIDSS), the bridge's get_modes() is never called. Instead, the
> drm_bridge_connector helper calls the bridge's edid_read() and updates the
> connector itself. This meant sink_is_hdmi was never populated, causing the
> driver to default to DVI mode and breaking HDMI audio.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/bridge: sii902x: Fix HDMI detection with DRM_BRIDGE_ATTACH_NO_CONNECTOR
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d6732ef4ab252e5753be7acad87b0a91cfd06953

-- 
Neil