linux-kernel - Re: [PATCH 3/6 v7] acpi/ghes: Make GHES select ACPI_APEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19155ced-8702-71f9-6eba-4dbfdc7c88ad@huawei.com>
Date: Fri, 21 Nov 2025 10:12:11 +0800
From: Hanjun Guo <guohanjun@...wei.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>, "Fabio M. De Francesco"
	<fabio.m.de.francesco@...ux.intel.com>
CC: <linux-cxl@...r.kernel.org>, "Rafael J . Wysocki" <rafael@...nel.org>, Len
 Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>, Borislav Petkov
	<bp@...en8.de>, Mauro Carvalho Chehab <mchehab@...nel.org>, Shuai Xue
	<xueshuai@...ux.alibaba.com>, Davidlohr Bueso <dave@...olabs.net>, Dave Jiang
	<dave.jiang@...el.com>, Alison Schofield <alison.schofield@...el.com>, Vishal
 Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>, Dan
 Williams <dan.j.williams@...el.com>, Mahesh J Salgaonkar
	<mahesh@...ux.ibm.com>, Oliver O'Halloran <oohall@...il.com>, Bjorn Helgaas
	<bhelgaas@...gle.com>, <linux-kernel@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-pci@...r.kernel.org>
Subject: Re: [PATCH 3/6 v7] acpi/ghes: Make GHES select ACPI_APEI_PCIEAER

On 2025/11/11 23:42, Jonathan Cameron wrote:
> On Tue,  4 Nov 2025 19:22:34 +0100
> "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com> wrote:
> 
>> GHES handles the PCI Express Error Section and also the Compute Express
>> Link (CXL) Protocol Error Section. Two of its functions depend on the
>> APEI PCIe AER logging/recovering support (ACPI_APEI_PCIEAER).
>>
>> Make GHES select ACPI_APEI_PCIEAER and remove the conditional
>> compilation from the body of two static functions that handle the CPER
>> Error Sections mentioned above.
> 
> Hi Fabio,
> 
> I'm not seeing a justification here for the change and there may be
> APEI platforms without PCI support.  So is this just to simplify things or
> is there a functional reason that it is necessary?

I have the same worry, embedded system with ACPI support may don't have
PCI. And for APEI, AER is one of the error type and optional.

Thanks
Hanjun