linux-kernel - Re: [PATCH] watchdog: sbsa: Update the W

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf2dd43c-f795-4b07-8de2-26856e42f7d6@roeck-us.net>
Date: Fri, 21 Nov 2025 07:49:36 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Naina Mehta <naina.mehta@....qualcomm.com>, wim@...ux-watchdog.org
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
 Aaron Plattner <aplattner@...dia.com>
Subject: Re: [PATCH] watchdog: sbsa: Update the W_IIDR Implementer bit mask to
 0xFFF

On 11/20/25 22:14, Naina Mehta wrote:
> The implementer mask defined in the driver [1] captures bits 0-10,
> whereas section C.4.2 of BSA specification [2] indicates that bits
> 0-11 of the W_IIDR register represent the implementer JEP106 code.
> Update the SBSA_GWDT_IMPL_MASK corresponding to bits 0-11, while
> at it update SBSA_GWDT_VERSION_MASK mask to use GENMASK.
> 
> [1] #define SBSA_GWDT_IMPL_MASK    0x7FF
> 
> [2] Implementer, bits [11:0]
> Contains the JEP106 code of the company that implemented the
> Generic Watchdog:
> Bits[11:8] The JEP106 continuation code of the implementer.
> Bit[7] Always 0
> Bits [6:0] The JEP106 identity code of the implementer.
> 
> Signed-off-by: Naina Mehta <naina.mehta@....qualcomm.com>
> Acked-by: Aaron Plattner <aplattner@...dia.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> * Link to RFC: https://lore.kernel.org/all/20251104063937.839138-1-naina.mehta@oss.qualcomm.com/
> 
>   drivers/watchdog/sbsa_gwdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index 6ce1bfb39064..f7cdc277eb3f 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -72,10 +72,10 @@
>   #define SBSA_GWDT_WCS_WS0	BIT(1)
>   #define SBSA_GWDT_WCS_WS1	BIT(2)
>   
> -#define SBSA_GWDT_VERSION_MASK  0xF
> +#define SBSA_GWDT_VERSION_MASK  GENMASK(3, 0)
>   #define SBSA_GWDT_VERSION_SHIFT 16
>   
> -#define SBSA_GWDT_IMPL_MASK	0x7FF
> +#define SBSA_GWDT_IMPL_MASK	GENMASK(11, 0)
>   #define SBSA_GWDT_IMPL_SHIFT	0
>   #define SBSA_GWDT_IMPL_MEDIATEK	0x426
>