linux-kernel - Re: [PATCH] usb: gadget: f_uac1: fix coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025112110-faculty-subtly-84a3@gregkh>
Date: Fri, 21 Nov 2025 17:26:48 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Sameeksha Sankpal <sameekshasankpal@...il.com>
Cc: sumanth.gavini@...oo.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: f_uac1: fix coding style warnings

On Fri, Nov 21, 2025 at 09:42:40PM +0530, Sameeksha Sankpal wrote:
> Fix several checkpatch.pl warnings in f_uac1.c including:
> - replace NULL comparisons with !ptr
> - remove unnecessary parentheses around simple equality checks
> - remove a redundant 'else' after a return statement
> - clean up superfluous blank lines
> - use 'unsigned int' instead of bare 'unsigned'
> - enclose a macro with complex value (USBDHDR) in parentheses
> 
> These changes clean up coding style and improve readability without
> altering the behavior of the driver.
> 
> Signed-off-by: Sameeksha Sankpal <sameekshasankpal@...il.com>

Please do not do coding style cleanups all in one patch, nor for
subsystems that maintainers do not explicitly state they want them for,
as it can cause unneeded constant churn.

please do this in drivers/staging/ first.

thanks,

greg k-h