linux-kernel - Re: [PATCH V15 1/6] mm: softdirty: Add pgtable_supports_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dac6ddfe-773a-43d5-8f69-021b9ca4d24b@lucifer.local>
Date: Fri, 21 Nov 2025 16:57:17 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Chunyan Zhang <zhangchunyan@...as.ac.cn>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>, linux-mm@...ck.org,
        Peter Xu <peterx@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        David Hildenbrand <david@...hat.com>,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Yuanchu Xie <yuanchu@...gle.com>, linux-riscv@...ts.infradead.org,
        Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
        devicetree@...r.kernel.org, Conor Dooley <conor@...nel.org>,
        Deepak Gupta <debug@...osinc.com>, Ved Shanbhogue <ved@...osinc.com>,
        linux-fsdevel@...r.kernel.org, Christian Brauner <brauner@...nel.org>,
        Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH V15 1/6] mm: softdirty: Add pgtable_supports_soft_dirty()

Hi Chunyan,

This breaks the VMA tests. Don't worry it's not exactly an obvious thing.

You can test this via:

$ cd tools/testing/vma
$ make && ./vma

(Currently we also have another breakage too which I'll chase up separately.)

Andrew - Could we simply apply the attached fix-patch?

I know this is in mm-stable now so ugh maybe we'll have some commits where VMA
tests are broken (not nice for bisection), but anyway we need to fix this even
so even if it has to be a follow up patch.

Thanks, Lorenzo

----8<----
>From b68d84af7030ac6db6174749a5b822d9afad8ff6 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Date: Fri, 21 Nov 2025 16:55:37 +0000
Subject: [PATCH] fixup

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
---
 tools/testing/vma/vma_internal.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/vma/vma_internal.h b/tools/testing/vma/vma_internal.h
index 81b501f51948..be99056c5d56 100644
--- a/tools/testing/vma/vma_internal.h
+++ b/tools/testing/vma/vma_internal.h
@@ -212,6 +212,8 @@ typedef __bitwise unsigned int vm_fault_t;

 #define ASSERT_EXCLUSIVE_WRITER(x)

+#define pgtable_supports_soft_dirty() 1
+
 /**
  * swap - swap values of @a and @b
  * @a: first value
--
2.51.2