linux-kernel - Re: [PATCH 0/8] rust: pci: add abstractions for SR-IOV capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aSCbxjbNJPPy2NVd@earendel>
Date: Fri, 21 Nov 2025 12:05:10 -0500
From: Peter Colberg <pcolberg@...hat.com>
To: Zhi Wang <zhiw@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Abdiel Janulgue <abdiel.janulgue@...il.com>,
	Daniel Almeida <daniel.almeida@...labora.com>,
	Robin Murphy <robin.murphy@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dave Ertman <david.m.ertman@...el.com>,
	Ira Weiny <ira.weiny@...el.com>, Leon Romanovsky <leon@...nel.org>,
	linux-pci@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alexandre Courbot <acourbot@...dia.com>,
	Alistair Popple <apopple@...dia.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	John Hubbard <jhubbard@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH 0/8] rust: pci: add abstractions for SR-IOV capability

On Thu, Nov 20, 2025 at 08:34:44PM +0200, Zhi Wang wrote:
> On Thu, 20 Nov 2025 10:03:45 -0500
> Peter Colberg <pcolberg@...hat.com> wrote:
> 
> Hi Peter:
> 
> I met some errors when compiling on driver-core-next branch, you can
> fix those in the next spin.
> 
> Fixes:
> 
> diff --git a/drivers/gpu/nova-core/driver.rs
> b/drivers/gpu/nova-core/driver.rs index ca0d5f8ad54b..730e745cad63
> 100644 --- a/drivers/gpu/nova-core/driver.rs
> +++ b/drivers/gpu/nova-core/driver.rs
> @@ -49,6 +49,7 @@ pub(crate) struct NovaCore {
>      ]
>  );
>  
> +#[vtable]
>  impl pci::Driver for NovaCore {
>      type IdInfo = ();
>      const ID_TABLE: pci::IdTable<Self::IdInfo> = &PCI_TABLE;
> 
> diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
> index d6cc5d7e7cd7..2d68db076f92 100644
> --- a/rust/kernel/pci.rs
> +++ b/rust/kernel/pci.rs
> @@ -292,6 +292,7 @@ macro_rules! pci_device_table {
>  ///     ]
>  /// );
>  ///
> +/// #[vtable]
>  /// impl pci::Driver for MyDriver {
>  ///     type IdInfo = ();
>  ///     const ID_TABLE: pci::IdTable<Self::IdInfo> = &PCI_TABLE;
> 
> The code in the examples should be able to compile.
> 
> You can enable doctest by:
> 
> CONFIG_RUST_KERNEL_DOCTESTS=y
> 
> Then:
> 
> impl Device<device::Bound> {
>     /// Returns the Physical Function (PF) device for a Virtual
> Function (VF) device. ///
>     /// # Examples
>     ///
> 
> snip
> 
>     /// ```
>     /// let pf_pdev = vf_pdev.physfn()?;
>     /// let pf_drvdata = pf_pdev.as_ref().drvdata::<MyDriver>()?;
> 
> I saw this part is not able to be compiled.^

Thanks Zhi, I applied all fixes.

Peter

> 
> Z.
> 
> > On Thu, Nov 20, 2025 at 08:32:13AM +0200, Zhi Wang wrote:
> > > On Wed, 19 Nov 2025 17:19:04 -0500
> > > Peter Colberg <pcolberg@...hat.com> wrote:
> > > 
> > > Hi Peter:
> > > 
> > > Thanks for the patches. :) I will test them with nova-core and come
> > > back with Tested-bys.
> > 
> > Perfect, thanks Zhi.
> > 
> > > Nit: Let's use "kernel vertical" styles on imports. [1]
> > > 
> > > [1]
> > > https://lore.kernel.org/all/20251105120352.77603-1-dakr@kernel.org/
> > 
> > Thanks, done for patch "samples: rust: add SR-IOV driver sample".
> > 
> > Peter
> > 
> > > 
> > > > Add Rust abstractions for the Single Root I/O Virtualization
> > > > (SR-IOV) capability of a PCI device. Provide a minimal set of
> > > > wrappers for the SR-IOV C API to enable and disable SR-IOV for a
> > > > device, and query if a PCI device is a Physical Function (PF) or
> > > > Virtual Function (VF).
> > > > 
> > > > Using the #[vtable] attribute, extend the pci::Driver trait with
> > > > an optional bus callback sriov_configure() that is invoked when a
> > > > user-space application writes the number of VFs to the sysfs file
> > > > `sriov_numvfs` to enable SR-IOV, or zero to disable SR-IOV [1].
> > > > 
> > > > Add a method physfn() to return the Physical Function (PF) device
> > > > for a Virtual Function (VF) device in the bound device context.
> > > > Unlike for a PCI driver written in C, guarantee that when a VF
> > > > device is bound to a driver, the underlying PF device is bound to
> > > > a driver, too.
> > > > 
> > > > When a device with enabled VFs is unbound from a driver, invoke
> > > > the sriov_configure() callback to disable SR-IOV before the
> > > > unbind() callback. To ensure the guarantee is upheld, call
> > > > disable_sriov() to remove all VF devices if the driver has not
> > > > done so already.
> > > > 
> > > > This series is based on Danilo Krummrich's series
> > > > "Device::drvdata() and driver/driver interaction (auxiliary)"
> > > > applied to driver-core-next, which similarly guarantees that when
> > > > an auxiliary bus device is bound to a driver, the underlying
> > > > parent device is bound to a driver, too [2].
> > > > 
> > > > Add an SR-IOV driver sample that exercises the SR-IOV capability
> > > > using QEMU's 82576 (igb) emulation and was used to test the
> > > > abstractions [3].
> > > > 
> > > > [1] https://docs.kernel.org/PCI/pci-iov-howto.html
> > > > [2]
> > > > https://lore.kernel.org/rust-for-linux/20251020223516.241050-1-dakr@kernel.org/
> > > > [3] https://www.qemu.org/docs/master/system/devices/igb.html
> > > > 
> > > > Signed-off-by: Peter Colberg <pcolberg@...hat.com>
> > > > ---
> > > > John Hubbard (1):
> > > >       rust: pci: add is_virtfn(), to check for VFs
> > > > 
> > > > Peter Colberg (7):
> > > >       rust: pci: add is_physfn(), to check for PFs
> > > >       rust: pci: add {enable,disable}_sriov(), to control SR-IOV
> > > > capability rust: pci: add num_vf(), to return number of VFs
> > > >       rust: pci: add vtable attribute to pci::Driver trait
> > > >       rust: pci: add bus callback sriov_configure(), to control
> > > > SR-IOV from sysfs rust: pci: add physfn(), to return PF device
> > > > for VF device samples: rust: add SR-IOV driver sample
> > > > 
> > > >  MAINTAINERS                           |   1 +
> > > >  rust/kernel/pci.rs                    | 148
> > > > ++++++++++++++++++++++++++++++++++ samples/rust/Kconfig
> > > >    |  11 +++ samples/rust/Makefile                 |   1 +
> > > >  samples/rust/rust_dma.rs              |   1 +
> > > >  samples/rust/rust_driver_auxiliary.rs |   1 +
> > > >  samples/rust/rust_driver_pci.rs       |   1 +
> > > >  samples/rust/rust_driver_sriov.rs     | 107
> > > > ++++++++++++++++++++++++ 8 files changed, 271 insertions(+)
> > > > ---
> > > > base-commit: e4addc7cc2dfcc19f1c8c8e47f3834b22cb21559
> > > > change-id: 20251026-rust-pci-sriov-ca8f501b2ae3
> > > > 
> > > > Best regards,
> > > 
> > 
> > 
>