linux-kernel - Re: [PATCH 5.15 000/411] 5.15.186-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202511210951.39AA2F97@keescook>
Date: Fri, 21 Nov 2025 10:00:53 -0800
From: Kees Cook <kees@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>, stable@...r.kernel.org,
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
	lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
	f.fainelli@...il.com, sudipm.mukherjee@...il.com,
	srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
	hargar@...rosoft.com, broonie@...nel.org,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Valdis Klētnieks <valdis.kletnieks@...edu>
Subject: Re: [PATCH 5.15 000/411] 5.15.186-rc1 review

On Fri, Nov 21, 2025 at 10:36:22AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 06, 2025 at 11:32:18AM -0800, Kees Cook wrote:
> > This thread got pointed out to me. You can put this back in if you want;
> > you just need the other associated fix (which had a bit of an obscure
> > Fixes tag):
> 
> What exactly is "this" commit?
> 
> > d8720235d5b5 ("scsi: qedf: Use designated initializer for struct qed_fcoe_cb_ops")
> 
> Can you give a list of git ids asked for here?  This thread is confusing
> :)

Sorry! For stable, you want these, if they're not already present:

960013ec5b5e ("net: qede: Initialize qede_ll_ops with designated initializer")
d8720235d5b5 ("scsi: qedf: Use designated initializer for struct qed_fcoe_cb_ops")
e136a4062174 ("randstruct: gcc-plugin: Remove bogus void member")
f39f18f3c353 ("randstruct: gcc-plugin: Fix attribute addition")


An additional bit of confusion is that the fix in 960013ec5b5e landed
twice via 2 trees:
6b3ab7f2cbfa ("net: qede: Initialize qede_ll_ops with designated initializer")
960013ec5b5e ("net: qede: Initialize qede_ll_ops with designated initializer")

Obviously either is fine.


-- 
Kees Cook