linux-kernel - Re: [PATCH 1/2] dt-bindings: mux: gpio-mux: add support for ADG1712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251121-privatize-decibel-72a37d50d269@spud>
Date: Fri, 21 Nov 2025 18:25:28 +0000
From: Conor Dooley <conor@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Peter Rosin <peda@...ntia.se>, Conor Dooley <conor+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Srinivas Kandagatla <srini@...nel.org>, devicetree@...r.kernel.org,
	Johan Hovold <johan+linaro@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, linux-kernel@...r.kernel.org,
	David Lechner <dlechner@...libre.com>
Subject: Re: [PATCH 1/2] dt-bindings: mux: gpio-mux: add support for ADG1712

On Fri, Nov 21, 2025 at 07:44:57AM -0600, Rob Herring (Arm) wrote:
> 
> On Fri, 21 Nov 2025 11:57:31 +0000, Antoniu Miclaus wrote:
> > Add support for the Analog Devices ADG1712 quad SPST switch to the
> > existing GPIO multiplexer bindings. The ADG1712 contains four
> > independent single-pole/single-throw (SPST) switches, each controlled
> > by a dedicated GPIO pin.
> > 
> > Unlike traditional multiplexers that use GPIOs as binary-encoded
> > selectors, the ADG1712 treats each GPIO as a direct switch controller.
> > The mux state represents the combination of all four switches, with
> > values from 0-15 corresponding to different switch combinations.
> > 
> > For example, state 5 (binary 0101) represents:
> > - SW1: ON (GPIO0 = 1)
> > - SW2: OFF (GPIO1 = 0)
> > - SW3: ON (GPIO2 = 1)
> > - SW4: OFF (GPIO3 = 0)
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > ---
> >  .../devicetree/bindings/mux/gpio-mux.yaml     | 24 ++++++++++++++++++-
> >  1 file changed, 23 insertions(+), 1 deletion(-)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mux/gpio-mux.example.dtb: switch-controller (adi,adg1712): $nodename:0: 'switch-controller' does not match '^mux-controller(@.*|-([0-9]|[1-9][0-9]+))?$'
> 	from schema $id: http://devicetree.org/schemas/mux/mux-controller.yaml

There's a patch relaxing this restriction here:
https://lore.kernel.org/all/cb7c28ccf3a1b136e793b48720f816de7d5f75b2.1763737324.git.tommaso.merciai.xr@bp.renesas.com/

> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251121115750.20119-2-antoniu.miclaus@analog.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)