linux-kernel - Re: [PATCH v3 07/16] mm: avoid unnecessary use of is_swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251121115550.8a8f9b39189b215849ce165d@linux-foundation.org>
Date: Fri, 21 Nov 2025 11:55:50 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Vlastimil Babka <vbabka@...e.cz>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Janosch Frank <frankja@...ux.ibm.com>, Claudio
 Imbrenda <imbrenda@...ux.ibm.com>, David Hildenbrand <david@...hat.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>, Gerald Schaefer
 <gerald.schaefer@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Peter Xu
 <peterx@...hat.com>, Alexander Viro <viro@...iv.linux.org.uk>, Christian
 Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, Arnd Bergmann
 <arnd@...db.de>, Zi Yan <ziy@...dia.com>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, "Liam R . Howlett"
 <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>, Ryan Roberts
 <ryan.roberts@....com>, Dev Jain <dev.jain@....com>, Barry Song
 <baohua@...nel.org>, Lance Yang <lance.yang@...ux.dev>, Muchun Song
 <muchun.song@...ux.dev>, Oscar Salvador <osalvador@...e.de>, Mike Rapoport
 <rppt@...nel.org>, Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko
 <mhocko@...e.com>, Matthew Brost <matthew.brost@...el.com>, Joshua Hahn
 <joshua.hahnjy@...il.com>, Rakie Kim <rakie.kim@...com>, Byungchul Park
 <byungchul@...com>, Gregory Price <gourry@...rry.net>, Ying Huang
 <ying.huang@...ux.alibaba.com>, Alistair Popple <apopple@...dia.com>, Axel
 Rasmussen <axelrasmussen@...gle.com>, Yuanchu Xie <yuanchu@...gle.com>, Wei
 Xu <weixugc@...gle.com>, Kemeng Shi <shikemeng@...weicloud.com>, Kairui
 Song <kasong@...cent.com>, Nhat Pham <nphamcs@...il.com>, Baoquan He
 <bhe@...hat.com>, Chris Li <chrisl@...nel.org>, SeongJae Park
 <sj@...nel.org>, Matthew Wilcox <willy@...radead.org>, Jason Gunthorpe
 <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Xu Xin
 <xu.xin16@....com.cn>, Chengming Zhou <chengming.zhou@...ux.dev>, Jann Horn
 <jannh@...gle.com>, Miaohe Lin <linmiaohe@...wei.com>, Naoya Horiguchi
 <nao.horiguchi@...il.com>, Pedro Falcato <pfalcato@...e.de>, Pasha Tatashin
 <pasha.tatashin@...een.com>, Rik van Riel <riel@...riel.com>, Harry Yoo
 <harry.yoo@...cle.com>, Hugh Dickins <hughd@...gle.com>,
 linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 linux-s390@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, linux-arch@...r.kernel.org, damon@...ts.linux.dev
Subject: Re: [PATCH v3 07/16] mm: avoid unnecessary use of is_swap_pmd()

On Fri, 21 Nov 2025 19:25:46 +0000 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:

> > > To add to the confusion in this terminology we use is_swap_pmd() in an
> > > inconsistent way similar to how is_swap_pte() was being used - sometimes
> > > adopting the convention that pmd_none(), !pmd_present() implies PMD 'swap'
> >
> > 			       !pmd_none()
> >
> > ?
> 
> Yeah sorry this is a typo.
> 
> Andrew, if it's easy to fix could you?

a few hours ago ;)

> If too late then never mind :)

"too late" is a thing I try to avoid!