linux-kernel - Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8c4a2420a5f57f4a646ca7abee86a203ac4bf79.camel@mediatek.com>
Date: Fri, 21 Nov 2025 03:07:12 +0000
From: Shunxi Zhang (章顺喜)
	<ot_shunxi.zhang@...iatek.com>
To: Eddie Huang (黃智傑) <eddie.huang@...iatek.com>,
	"alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
	Vince-WL Liu (劉文龍) <Vince-WL.Liu@...iatek.com>,
	"krzk@...nel.org" <krzk@...nel.org>, Jh Hsu (許希孜)
	<Jh.Hsu@...iatek.com>, Sean Wang <Sean.Wang@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "lee@...nel.org" <lee@...nel.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY
 definition

On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:17, ot_shunxi.zhang@...iatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> > 
> > Adjust the whitespace alignment for the RTC_BBPU_KEY macro
> > definition
> > in the mt6397 RTC header file. This is a cosmetic change to improve
> > code consistency.
> 
> Please don't send such changes line by line.. You have other patches
> here doing the same. Organize all such trivial stuff, including for
> other drivers not only this one (!!),  in one patch. This is just
> churn.
> 
> 
> 
> Best regards,
> Krzysztof

Dear sir,
Execuse me,
do you mean we shouldn't make the "formatting changes" a separate
patch? This was based on a previous comment: 
https://patchwork.kernel.org/project/linux-mediatek/patch/20250811081543.4377-2-ot_shunxi.zhang@mediatek.com/#26517538. If it doesn't need to be a separate patch, I will make it into a patch with other changes in the next version.

Best Regards
Shunxi Zhang