linux-kernel - Re: [PATCH v6 2/4] crypto: ti - Add support for AES-CTR in DTHEv2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR_YR_nF4sjUlgN6@gondor.apana.org.au>
Date: Fri, 21 Nov 2025 11:11:03 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: T Pratham <t-pratham@...com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Manorit Chawdhry <m-chawdhry@...com>,
	Kamlesh Gurudasani <kamlesh@...com>,
	Shiva Tripathi <s-tripathi1@...com>,
	Kavitha Malarvizhi <k-malarvizhi@...com>,
	Vishal Mahaveer <vishalm@...com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/4] crypto: ti - Add support for AES-CTR in DTHEv2
 driver

On Tue, Nov 11, 2025 at 04:38:31PM +0530, T Pratham wrote:
>
> @@ -270,12 +326,17 @@ static int dthe_aes_run(struct crypto_engine *engine, void *areq)
>  	struct scatterlist *src = req->src;
>  	struct scatterlist *dst = req->dst;
>  
> +	struct scatterlist src_pad[2], dst_pad[2];
> +
>  	int src_nents = sg_nents_for_len(src, len);
> -	int dst_nents;
> +	int dst_nents = sg_nents_for_len(dst, len);
>  
>  	int src_mapped_nents;
>  	int dst_mapped_nents;
>  
> +	u8 pad_buf[AES_BLOCK_SIZE] = {0};

You can't put stack memory into an SG list since the ability to
DMA to the stack is not guaranteed.

I suggest that you place the buffer into the request object instead.
The request object is designed to allow DMA and you can allocate as
much memory as you like by setting reqsize.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt