linux-kernel - Re: [PATCH -next] arm_mpam: Remove duplicate linux/srcu.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac5715f0-6efb-4e58-be6c-e8b3a15b4e1e@nvidia.com>
Date: Fri, 21 Nov 2025 15:15:22 -0800
From: Fenghua Yu <fenghuay@...dia.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, james.morse@....com
Cc: ben.horgan@....com, reinette.chatre@...el.com,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] arm_mpam: Remove duplicate linux/srcu.h header

Hi, Jiapeng,

On 11/20/25 19:39, Jiapeng Chong wrote:
> ./drivers/resctrl/mpam_internal.h: linux/srcu.h is included more than once.
> 

Do you need to add "Fixes:" here?
Fixes: 8c90dc68a5de ("arm_mpam: Probe the hardware features resctrl 
supports")

Not sure it's necessary for this minor fix but 
Documentations/process/submitting-patches.rst says "If your patch fixes 
a bug in a specific commit, e.g. you found an issue using
``git bisect``, please use the 'Fixes:' tag with at least the first 12
characters of the SHA-1 ID, and the one line summary.  Do not split the tag
across multiple lines, tags are exempt from the "wrap at 75 columns" rule in
order to simplify parsing scripts."

> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27328
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/resctrl/mpam_internal.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h
> index e79c3c47259c..f733bed011bd 100644
> --- a/drivers/resctrl/mpam_internal.h
> +++ b/drivers/resctrl/mpam_internal.h
> @@ -14,7 +14,6 @@
>   #include <linux/mutex.h>
>   #include <linux/srcu.h>
>   #include <linux/spinlock.h>
> -#include <linux/srcu.h>
>   #include <linux/types.h>
>   
>   #define MPAM_MSC_MAX_NUM_RIS	16

Thanks.

-Fenghua