linux-kernel - Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37dc95982cc37fbd78b8fee6c11b709d3171bd7a.camel@mediatek.com>
Date: Fri, 21 Nov 2025 03:20:27 +0000
From: Shunxi Zhang (章顺喜)
	<ot_shunxi.zhang@...iatek.com>
To: Eddie Huang (黃智傑) <eddie.huang@...iatek.com>,
	"alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
	Vince-WL Liu (劉文龍) <Vince-WL.Liu@...iatek.com>,
	"krzk@...nel.org" <krzk@...nel.org>, Jh Hsu (許希孜)
	<Jh.Hsu@...iatek.com>, Sean Wang <Sean.Wang@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "lee@...nel.org" <lee@...nel.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and
 shutdown handling

On Thu, 2025-11-20 at 14:40 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:18, ot_shunxi.zhang@...iatek.com wrote:
> > 
> >       rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc),
> > GFP_KERNEL);
> > @@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device
> > *pdev)
> >       if (IS_ERR(rtc->rtc_dev))
> >               return PTR_ERR(rtc->rtc_dev);
> > 
> > +     rtc->alarm_sta_supported = of_property_read_bool(np,
> > "mediatek,alarm-sta-supported");
> 
> You cannot add undocumented ABI. Read carefully Linux documentation.
> 
> Best regards,
> Krzysztof

Dear sir,
  Thanks for your comment, I will read & check linux documentation.
It will be revised in the next version.

Best Regards
Shunxi Zhang