| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGXv+5HZbB+CeeM7ggCRmxdiyeY-5tXYpLLTyoazEinrLe_jCw@mail.gmail.com>
Date: Fri, 21 Nov 2025 13:55:05 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Cyril Chao <Cyril.Chao@...iatek.com>, Arnd Bergmann <arnd@...db.de>,
Nícolas F. R. A. Prado <nfraprado@...labora.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
upstream@...oha.com
Subject: Re: [PATCH v2 3/3] ASoC: airoha: Add AFE and machine driver for
Airoha AN7581
On Fri, Nov 21, 2025 at 1:46 PM Christian Marangi <ansuelsmth@...il.com> wrote:
>
> Add support for the Sound system present on Airoha AN7581 SoC. This is
> based on the mediatek AFE drivers.
>
> Also add the machine driver to create an actual sound card for the AFE.
>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
[...]
> diff --git a/sound/soc/mediatek/an7581/an7581-wm8960.c b/sound/soc/mediatek/an7581/an7581-wm8960.c
> new file mode 100644
> index 000000000000..5d6c736aa6f2
> --- /dev/null
> +++ b/sound/soc/mediatek/an7581/an7581-wm8960.c
> @@ -0,0 +1,170 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Airoha ALSA SoC I2S platform driver for AN7581
> + *
> + */
> +
> +#include <linux/module.h>
> +#include <sound/soc.h>
> +
> +#include "an7581-afe-common.h"
> +
> +static const struct snd_soc_dapm_widget an7581_wm8960_widgets[] = {
> + SND_SOC_DAPM_HP("Headphone", NULL),
> + SND_SOC_DAPM_MIC("AMIC", NULL),
> +};
> +
> +static const struct snd_kcontrol_new an7581_wm8960_controls[] = {
> + SOC_DAPM_PIN_SWITCH("Headphone"),
> + SOC_DAPM_PIN_SWITCH("AMIC"),
> +};
> +
> +SND_SOC_DAILINK_DEFS(playback,
> + DAILINK_COMP_ARRAY(COMP_CPU("DL1")),
> + DAILINK_COMP_ARRAY(COMP_DUMMY()),
> + DAILINK_COMP_ARRAY(COMP_EMPTY()));
> +
> +SND_SOC_DAILINK_DEFS(capture,
> + DAILINK_COMP_ARRAY(COMP_CPU("UL1")),
> + DAILINK_COMP_ARRAY(COMP_DUMMY()),
> + DAILINK_COMP_ARRAY(COMP_EMPTY()));
> +
> +SND_SOC_DAILINK_DEFS(codec,
> + DAILINK_COMP_ARRAY(COMP_CPU("ETDM")),
> + DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "wm8960-hifi")),
> + DAILINK_COMP_ARRAY(COMP_EMPTY()));
> +
> +static struct snd_soc_dai_link an7581_wm8960_dai_links[] = {
> + /* FE */
> + {
> + .name = "wm8960-playback",
> + .stream_name = "wm8960-playback",
> + .trigger = {SND_SOC_DPCM_TRIGGER_POST,
> + SND_SOC_DPCM_TRIGGER_POST},
> + .dynamic = 0,
> + .playback_only = 1,
> + SND_SOC_DAILINK_REG(playback),
> + },
> + {
> + .name = "wm8960-capture",
> + .stream_name = "wm8960-capture",
> + .trigger = {SND_SOC_DPCM_TRIGGER_POST,
> + SND_SOC_DPCM_TRIGGER_POST},
> + .dynamic = 0,
> + .capture_only = 1,
> + SND_SOC_DAILINK_REG(capture),
> + },
> + /* BE */
> + {
> + .name = "wm8960-codec",
> + .no_pcm = 1,
> + .dai_fmt = SND_SOC_DAIFMT_I2S |
> + SND_SOC_DAIFMT_NB_NF |
> + SND_SOC_DAIFMT_CBC_CFC |
> + SND_SOC_DAIFMT_GATED,
> + SND_SOC_DAILINK_REG(codec),
> + },
> +};
> +
> +static struct snd_soc_card an7581_wm8960_card = {
> + .name = "an7581-wm8960",
> + .owner = THIS_MODULE,
> + .dai_link = an7581_wm8960_dai_links,
> + .num_links = ARRAY_SIZE(an7581_wm8960_dai_links),
> + .controls = an7581_wm8960_controls,
> + .num_controls = ARRAY_SIZE(an7581_wm8960_controls),
> + .dapm_widgets = an7581_wm8960_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(an7581_wm8960_widgets),
> +};
> +
> +static int an7581_wm8960_machine_probe(struct platform_device *pdev)
> +{
> + struct device_node *platform_dai_node, *codec_dai_node;
> + struct snd_soc_card *card = &an7581_wm8960_card;
> + struct device_node *platform, *codec;
> + struct snd_soc_dai_link *dai_link;
> + int ret, i;
> +
> + card->dev = &pdev->dev;
> +
> + platform = of_get_child_by_name(pdev->dev.of_node, "platform");
> +
> + if (platform) {
> + platform_dai_node = of_parse_phandle(platform, "sound-dai", 0);
> + of_node_put(platform);
> +
> + if (!platform_dai_node) {
> + dev_err(&pdev->dev, "Failed to parse platform/sound-dai property\n");
> + return -EINVAL;
> + }
> + } else {
> + dev_err(&pdev->dev, "Property 'platform' missing or invalid\n");
> + return -EINVAL;
> + }
> +
> + for_each_card_prelinks(card, i, dai_link) {
> + if (dai_link->platforms->name)
> + continue;
> + dai_link->platforms->of_node = platform_dai_node;
> + }
> +
> + codec = of_get_child_by_name(pdev->dev.of_node, "codec");
> +
> + if (codec) {
> + codec_dai_node = of_parse_phandle(codec, "sound-dai", 0);
> + of_node_put(codec);
> +
> + if (!codec_dai_node) {
> + of_node_put(platform_dai_node);
> + dev_err(&pdev->dev, "Failed to parse codec/sound-dai property\n");
> + return -EINVAL;
> + }
> + } else {
> + of_node_put(platform_dai_node);
> + dev_err(&pdev->dev, "Property 'codec' missing or invalid\n");
> + return -EINVAL;
> + }
> +
> + for_each_card_prelinks(card, i, dai_link) {
> + if (dai_link->codecs->name)
> + continue;
> + dai_link->codecs->of_node = codec_dai_node;
> + }
> +
> + ret = snd_soc_of_parse_audio_routing(card, "audio-routing");
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to parse audio-routing: %d\n", ret);
> + goto err_of_node_put;
> + }
> +
> + ret = devm_snd_soc_register_card(&pdev->dev, card);
> + if (ret) {
> + dev_err_probe(&pdev->dev, ret, "%s snd_soc_register_card fail\n", __func__);
> + goto err_of_node_put;
> + }
> +
> + return 0;
> +
> +err_of_node_put:
> + of_node_put(platform_dai_node);
> + of_node_put(codec_dai_node);
> + return ret;
> +}
> +
> +static const struct of_device_id an7581_wm8960_machine_dt_match[] = {
> + { .compatible = "airoha,an7581-wm8960-sound" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, an7581_wm8960_machine_dt_match);
> +
> +static struct platform_driver an7581_wm8960_driver = {
> + .driver = {
> + .name = "an7581-wm8960",
> + .of_match_table = an7581_wm8960_machine_dt_match,
> + },
> + .probe = an7581_wm8960_machine_probe,
> +};
> +module_platform_driver(an7581_wm8960_driver);
> +
> +MODULE_DESCRIPTION("Airoha SoC I2S platform driver for ALSA AN7581");
> +MODULE_LICENSE("GPL");
This machine driver seems very generic. Maybe you could get away with
using the audio graph drivers instead? It avoids tying the platform with
a specific codec just for boilerplate code.
ChenYu
Powered by blists - more mailing lists