linux-kernel - Re: [PATCH v8 06/18] media: ti: j721e-csi2rx: add a subdev for the core device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0096484-c2cc-47cb-940d-2bf003a38b1f@ti.com>
Date: Fri, 21 Nov 2025 12:29:52 +0530
From: Rishikesh Donadkar <r-donadkar@...com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
CC: <jai.luthra@...ux.dev>, <laurent.pinchart@...asonboard.com>,
	<mripard@...nel.org>, <y-abhilashchandra@...com>, <devarsht@...com>,
	<s-jain1@...com>, <vigneshr@...com>, <mchehab@...nel.org>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <p.zabel@...gutronix.de>, <conor+dt@...nel.org>,
	<hverkuil-cisco@...all.nl>, <tomi.valkeinen@...asonboard.com>,
	<jai.luthra@...asonboard.com>, <changhuang.liang@...rfivetech.com>,
	<jack.zhu@...rfivetech.com>, <sjoerd@...labora.com>,
	<dan.carpenter@...aro.org>, <hverkuil+cisco@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v8 06/18] media: ti: j721e-csi2rx: add a subdev for the
 core device


On 20/11/25 18:09, Sakari Ailus wrote:
> Hi Rishikesh,


Hi Sakari,

Thank you for the review.

>
> On Wed, Nov 12, 2025 at 05:24:47PM +0530, Rishikesh Donadkar wrote:
>> +static int ti_csi2rx_sd_s_stream(struct v4l2_subdev *sd, int enable)
> Could you instead implement enable_streams and disable_streams pad ops,
> please, and use v4l2_subdev_enable_streams() from there?


This is done in 08/18, I will merge changes form 08/18 in to this patch.

Rishikesh

>
>> +{
>> +	struct ti_csi2rx_dev *csi = to_csi2rx_dev(sd);
>> +	int ret = 0;
>> +
>> +	mutex_lock(&csi->mutex);
>> +
>> +	if (enable) {
>> +		if (csi->enable_count > 0) {
>> +			csi->enable_count++;
>> +			goto out;
>> +		}
>> +
>> +		ret = v4l2_subdev_call(csi->source, video, s_stream, 1);
>> +		if (ret)
>> +			goto out;
>> +
>> +		csi->enable_count++;
>> +	} else {
>> +		if (csi->enable_count == 0) {
>> +			ret = -EINVAL;
>> +			goto out;
>> +		}
>> +
>> +		if (--csi->enable_count > 0)
>> +			goto out;
>> +
>> +		ret = v4l2_subdev_call(csi->source, video, s_stream, 0);
>> +	}
>> +
>> +out:
>> +	mutex_unlock(&csi->mutex);
>> +	return ret;
>> +}