linux-kernel - Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c70dc3f-a994-4978-af26-0a3eb746fb5b@kernel.org>
Date: Fri, 21 Nov 2025 08:20:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shunxi Zhang (章顺喜)
 <ot_shunxi.zhang@...iatek.com>, Eddie Huang (黃智傑)
 <eddie.huang@...iatek.com>,
 "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
 Vince-WL Liu (劉文龍) <Vince-WL.Liu@...iatek.com>,
 Jh Hsu (許希孜) <Jh.Hsu@...iatek.com>,
 Sean Wang <Sean.Wang@...iatek.com>, "conor+dt@...nel.org"
 <conor+dt@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
 "lee@...nel.org" <lee@...nel.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY
 definition

On 21/11/2025 04:07, Shunxi Zhang (章顺喜) wrote:
> On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 20/11/2025 13:17, ot_shunxi.zhang@...iatek.com wrote:
>>> From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
>>>
>>> Adjust the whitespace alignment for the RTC_BBPU_KEY macro
>>> definition
>>> in the mt6397 RTC header file. This is a cosmetic change to improve
>>> code consistency.
>>
>> Please don't send such changes line by line.. You have other patches
>> here doing the same. Organize all such trivial stuff, including for
>> other drivers not only this one (!!),  in one patch. This is just
>> churn.
>>
>>
>>
>> Best regards,
>> Krzysztof
> 
> Dear sir,
> Execuse me,
> do you mean we shouldn't make the "formatting changes" a separate
> patch? This was based on a previous comment: 

Fix entire subsystem or multiple drivers not only one line.


Best regards,
Krzysztof