linux-kernel - Re: [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <653f362e-a32a-416e-89c6-d8c51abf2cce@amd.com>
Date: Fri, 21 Nov 2025 13:44:01 +0530
From: Vasant Hegde <vasant.hegde@....com>
To: Jinhui Guo <guojinhui.liam@...edance.com>, joro@...tes.org,
 suravee.suthikulpanit@....com, Ankit.Soni@....com
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in
 modify_irte_ga()

On 11/21/2025 10:51 AM, Jinhui Guo wrote:
> The return type of __modify_irte_ga() is int, but modify_irte_ga()
> treats it as a bool. Casting the int to bool discards the error code.
> 
> To fix the issue, change the type of ret to int in modify_irte_ga().
> 
> Fixes: 57cdb720eaa5 ("iommu/amd: Do not flush IRTE when only updating isRun and destination fields")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jinhui Guo <guojinhui.liam@...edance.com>
> Reviewed-by: Ankit Soni <Ankit.Soni@....com>

Reviewed-by: Vasant Hegde <vasant.hegde@....com>

-Vasant