linux-kernel - Re: [PATCH v6 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+zupgxskC2HMy_sLusDbb_L1t49frjLQW6isBfAKa6BgNvpNQ@mail.gmail.com>
Date: Fri, 21 Nov 2025 16:46:21 +0800
From: Roy Luo <royluo@...gle.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Peter Griffin <peter.griffin@...aro.org>, André Draszik <andre.draszik@...aro.org>, 
	Tudor Ambarus <tudor.ambarus@...aro.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Badhri Jagan Sridharan <badhri@...gle.com>, Doug Anderson <dianders@...gle.com>, linux-phy@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	Joy Chakraborty <joychakr@...gle.com>, Naveen Kumar <mnkumar@...gle.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY

On Fri, Nov 21, 2025 at 4:16 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Thu, Nov 20, 2025 at 05:36:41PM +0000, Roy Luo wrote:
>
> I read last discussion and patch is fine, except one issue in example I
> never noticed before (see at the end), which I want to fix. Apologies
> for not bringing it up anytime earlier, I missed it. While at it also
> one more nit.
>
> > +description: |
>
> nit: drop |, do not need '|' unless you need to preserve formatting.
>
> > +  Describes the USB PHY interfaces integrated with the DWC3 USB controller on
> > +  Google Tensor SoCs, starting with the G5 generation (laguna).
> > +  Two specific PHY IPs from Synopsys are integrated, including eUSB 2.0 PHY IP
> > +  and USB3.2/DisplayPort combo PHY IP.
>
> ...
>
> > > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        usb_phy: usb_phy@...0000 {
>
> node name: usb-phy, because there are no underscors used anywhere in
> upstream. While at it, you can drop the label as well, because it is not
> uised, so just usb-phy@..... {
>
> Please send new version with these two fixed and:
>
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> Best regards,
> Krzysztof
>

Thank you for the review, I appreciate it!
Ack on both points and will send out a new version.

Regards,
Roy Luo