linux-kernel - Re: [PATCH] dt-bindings: arm: qcom: add ipq8064 board variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ee9f41b-979f-4c44-a009-f0d94f6854b6@oss.qualcomm.com>
Date: Fri, 21 Nov 2025 10:19:33 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Christian Marangi <ansuelsmth@...il.com>, Rob Herring <robh@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: qcom: add ipq8064 board variants

On 11/20/25 11:49 PM, Christian Marangi wrote:
> On Thu, Nov 20, 2025 at 11:41:19AM -0600, Rob Herring wrote:
>> On Thu, Nov 20, 2025 at 04:31:47PM +0100, Christian Marangi wrote:
>>> On Thu, Nov 20, 2025 at 04:25:37PM +0100, Konrad Dybcio wrote:
>>>> On 11/20/25 2:54 PM, Christian Marangi wrote:
>>>>> Document QCOM ipq8064 board variants ipq8062, ipq8065, ipq8066,
>>>>> ipq8068, ipq8069 now matched by the QCOM cpufreq nvmem driver if
>>>>> socinfo can't derive the variant from SMEM.
>>>>>
>>>>> Suggested-by: Rob Herring <robh@...nel.org>
>>>>> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
>>>>> ---
>>>>>  .../devicetree/bindings/arm/qcom.yaml         | 20 +++++++++++++++++++
>>>>>  1 file changed, 20 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> index 18b5ed044f9f..0eb1619fede8 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> @@ -299,12 +299,32 @@ properties:
>>>>>                - qcom,ipq5424-rdp466
>>>>>            - const: qcom,ipq5424
>>>>>  
>>>>> +      - items:
>>>>> +          - const: qcom,ipq8062
>>>>> +          - const: qcom,ipq8064
>>>>
>>>> Since 'items' requires that all items are present (and in this order),
>>>> we would normally have a board name go first.. but I suppose this is
>>>> some sort of a fix to the issue that sparked this (posting the link
>>>> for others to have more context)
>>>>
>>>> But since these SoCs do exist, I wouldn't say this is necessarily
>>>> wrong..
>>>>
>>>
>>> Well we can see this as a ""template"" for device that might be added
>>> using the ipq8062 or ipq8065 compatible.
>>>
>>> When device with that variant will be added we would have to just add an
>>> enum with the real device name on top of it (as first element).
>>>
>>> Honestly I should have added these compatible long time ago as on
>>> OpenWrt we have tons of device that are ipq8062 or ipq8065 with the
>>> compatible structure
>>>
>>> "device,name", "qcom,ipq8065", "qcom,ipq8064".
>>
>> If you don't you have any boards yet, you can do:
>>
>> items:
>>   - description: ...
>>   - const: qcom,ipq8065
>>   - const: qcom,ipq8064
>>
>> Just to prevent skipping a board compatible.
>>
>> But you said you have tons of devices, so...
>>
> 
> Yes the problem is that it might take a while for the DTS to be picked
> so maybe it's better to push for the description solution?

DT depends on bindings, it's not so stringent the other way around

Konrad
>