linux-kernel - Re: [PATCH 1/9] block: fix data loss and stale date exposure problems during append write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72fb4c90-0a75-43df-8f5a-154d9e050c09@wdc.com>
Date: Fri, 21 Nov 2025 09:34:48 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: zhangshida <starzhangzsd@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"nvdimm@...ts.linux.dev" <nvdimm@...ts.linux.dev>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"gfs2@...ts.linux.dev" <gfs2@...ts.linux.dev>, "ntfs3@...ts.linux.dev"
	<ntfs3@...ts.linux.dev>, "linux-xfs@...r.kernel.org"
	<linux-xfs@...r.kernel.org>, "zhangshida@...inos.cn" <zhangshida@...inos.cn>
Subject: Re: [PATCH 1/9] block: fix data loss and stale date exposure problems
 during append write

On 11/21/25 9:19 AM, zhangshida wrote:
> From: Shida Zhang <zhangshida@...inos.cn>
>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>


Regardless of the code change, this needs documentation what you are 
doing and why it is correct

> ---
>   block/bio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bio.c b/block/bio.c
> index b3a79285c27..55c2c1a0020 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -322,7 +322,7 @@ static struct bio *__bio_chain_endio(struct bio *bio)
>   
>   static void bio_chain_endio(struct bio *bio)
>   {
> -	bio_endio(__bio_chain_endio(bio));
> +	bio_endio(bio);
>   }
>   
>   /**