linux-kernel - Re: [PATCH] ALSA: pcm: Harden the spk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjkv4tka.wl-tiwai@suse.de>
Date: Fri, 21 Nov 2025 10:35:17 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Umang Jain <uajain@...lia.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Dmitry Baryshkov <lumag@...nel.org>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel-dev@...lia.com
Subject: Re: [PATCH] ALSA: pcm: Harden the spk_alloc assumption check

On Thu, 20 Nov 2025 15:17:57 +0100,
Umang Jain wrote:
> 
> If the parsed ELD has spk_alloc=0, it currently assigns the parsed ELD
> spk_alloc to 0xffff. However, we should also check if there is at least
> one SAD (Short audio descriptor) to enforce the assumption, as ELD
> without any sad_count, is usually considered invalid for e.g. in
> commit ce9778b7a0272("ALSA: hda/hdmi: Consider ELD is invalid when no
> SAD is present").
> 
> Signed-off-by: Umang Jain <uajain@...lia.com>

Thanks, applied now.


Takashi