linux-kernel - Re: [PATCH 1/9] block: fix data loss and stale date exposure problems during append write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSA_dTktkC85K39o@infradead.org>
Date: Fri, 21 Nov 2025 02:31:17 -0800
From: Christoph Hellwig <hch@...radead.org>
To: zhangshida <starzhangzsd@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	nvdimm@...ts.linux.dev, virtualization@...ts.linux.dev,
	linux-nvme@...ts.infradead.org, gfs2@...ts.linux.dev,
	ntfs3@...ts.linux.dev, linux-xfs@...r.kernel.org,
	zhangshida@...inos.cn
Subject: Re: [PATCH 1/9] block: fix data loss and stale date exposure
 problems during append write

On Fri, Nov 21, 2025 at 04:17:40PM +0800, zhangshida wrote:
> From: Shida Zhang <zhangshida@...inos.cn>
> 
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> ---
>  block/bio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index b3a79285c27..55c2c1a0020 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -322,7 +322,7 @@ static struct bio *__bio_chain_endio(struct bio *bio)
>  
>  static void bio_chain_endio(struct bio *bio)
>  {
> -	bio_endio(__bio_chain_endio(bio));
> +	bio_endio(bio);

I don't see how this can work.  bio_chain_endio is called literally
as the result of calling bio_endio, so you recurse into that.

Also please put your analysis of the problem into this patch as
said by Johannes.  And please wrap it at 73 characters as the wall of
text in the cover letter is quite unreadable.