linux-kernel - Re: [PATCH 0/7] EDAC: Add Intel Diamond Rapids server support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251121105905.GAaSBF-XQZCXnR6UIx@fat_crate.local>
Date: Fri, 21 Nov 2025 11:59:05 +0100
From: Borislav Petkov <bp@...en8.de>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Cc: Tony Luck <tony.luck@...el.com>, Lai Yi <yi1.lai@...ux.intel.com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] EDAC: Add Intel Diamond Rapids server support

On Wed, Nov 19, 2025 at 09:41:24PM +0800, Qiuxu Zhuo wrote:
> Add a new EDAC driver for Intel Diamond Rapids CPUs. The reasons for a
> separate driver instead of building on top of previous EDAC driver are
> as follows:
> 
>   1) The memory controllers of Intel Diamond Rapids server CPUs are not
>      presented as PCI devices to the OS, unlike previous generations.
>      The enumeration and all memory controller registers have been
>      transitioned to MMIO-based memory spaces.
> 
>   2) Modifications to previous EDAC driver for Diamond Rapids CPUs would 
>      require extensive validation checks against multiple platforms,
>      including Ice Lake, Sapphire Rapids, Emerald Rapids, Granite Rapids,
>      Sierra Forest, and Grand Ridge.
> 
>   3) Future Intel CPUs will likely only need patches on top of this new
>      EDAC driver. Validation can be limited to Diamond Rapids servers
>      and future Intel CPU generations.
> 
> The patch series is constructed as following parts:
> 
>   Patch 1~3: Update the skx_common library to prepare for Diamond Rapids EDAC driver.
>   Patch   4: Add Diamond Rapids EDAC driver.
>   Patch   5: Extend DRAM chip row bits.
>   Patch   6: Detect 2-level memory configuration.
>   Patch   7: Add debugfs testing node.
> 
> Qiuxu Zhuo (7):
>   EDAC/{skx_common,skx,i10nm}: Make skx_register_mci() independent of pci_dev
>   EDAC/skx_common: Prepare for skx_get_edac_list()
>   EDAC/skx_common: Prepare for skx_set_hi_lo()
>   EDAC/{skx_common,imh}: Add EDAC driver for Intel Diamond Rapids servers
>   EDAC/skx_common: Extend the maximum number of DRAM chip row bits
>   EDAC/{skx_comm,imh}: Detect 2-level memory configuration
>   EDAC/imh: Setup 'imh_test' debugfs testing node
> 
>  drivers/edac/Kconfig      |  10 +
>  drivers/edac/Makefile     |   3 +
>  drivers/edac/i10nm_base.c |   3 +-
>  drivers/edac/imh_base.c   | 602 ++++++++++++++++++++++++++++++++++++++
>  drivers/edac/skx_base.c   |   4 +-
>  drivers/edac/skx_common.c |  33 ++-
>  drivers/edac/skx_common.h |  98 +++++--
>  7 files changed, 717 insertions(+), 36 deletions(-)
>  create mode 100644 drivers/edac/imh_base.c

ld: drivers/edac/skx_common.o: in function `skx_get_nvdimm_info':
skx_common.c:(.text+0x93c): undefined reference to `nfit_get_smbios_id'
make[2]: *** [scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
make[1]: *** [/home/amd/kernel/linux/Makefile:1242: vmlinux] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:248: __sub-make] Error 2

It must be coming from this set because I didn't see this before.

.config attached.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

View attachment "22-54-30-randconfig-x86_64-15734.cfg" of type "text/plain" (223258 bytes)