linux-kernel - [PATCH] crypto: hisilicon/qm - fix device leak on QoS updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251121111130.25025-1-johan@kernel.org>
Date: Fri, 21 Nov 2025 12:11:30 +0100
From: Johan Hovold <johan@...nel.org>
To: Weili Qian <qianweili@...wei.com>,
	Zhou Wang <wangzhou1@...ilicon.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S . Miller" <davem@...emloft.net>
Cc: Kai Ye <yekai13@...wei.com>,
	linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Johan Hovold <johan@...nel.org>,
	stable@...r.kernel.org
Subject: [PATCH] crypto: hisilicon/qm - fix device leak on QoS updates

Make sure to drop the reference taken when looking up the PCI device on
QoS updates.

Fixes: 22d7a6c39cab ("crypto: hisilicon/qm - add pci bdf number check")
Cc: stable@...r.kernel.org	# 6.2
Cc: Kai Ye <yekai13@...wei.com>
Signed-off-by: Johan Hovold <johan@...nel.org>
---
 drivers/crypto/hisilicon/qm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index a5b96adf2d1e..ef6fdcc3dbcb 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -3871,11 +3871,14 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
 	pdev = container_of(dev, struct pci_dev, dev);
 	if (pci_physfn(pdev) != qm->pdev) {
 		pci_err(qm->pdev, "the pdev input does not match the pf!\n");
+		put_device(dev);
 		return -EINVAL;
 	}
 
 	*fun_index = pdev->devfn;
 
+	put_device(dev);
+
 	return 0;
 }
 
-- 
2.51.2