linux-kernel - RE: [PATCH v3 05/13] serial: rsci: Drop unused TDR register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346DF06C496B6CEA1ECB7DC86D2A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sat, 22 Nov 2025 12:52:24 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, biju.das.au <biju.das.au@...il.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
	<jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, magnus.damm
	<magnus.damm@...il.com>, wsa+renesas <wsa+renesas@...g-engineering.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v3 05/13] serial: rsci: Drop unused TDR register

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 21 November 2025 15:01
> Subject: Re: [PATCH v3 05/13] serial: rsci: Drop unused TDR register
> 
> On Fri, 14 Nov 2025 at 11:52, Biju <biju.das.au@...il.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > Drop the unused TDR register-related macros.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> > --- a/drivers/tty/serial/rsci.c
> > +++ b/drivers/tty/serial/rsci.c
> > @@ -35,12 +35,6 @@ MODULE_IMPORT_NS("SH_SCI");
> >  #define RDR_FPER               BIT(11) /* FIFO Parity Error */
> >  #define RDR_RDAT_MSK           GENMASK(8, 0)
> >
> > -/* TDR (Transmit Data Register) */
> > -#define TDR_MPBT               BIT(9)  /* Multiprocessor Transfer */
> 
> Might be useful, one day. But all other bits do not have defines yet anyway.
> 
> > -#define TDR_TDAT_9BIT_LSHIFT   0
> > -#define TDR_TDAT_9BIT_VAL      0x1FF
> > -#define TDR_TDAT_9BIT_MSK      (TDR_TDAT_9BIT_VAL << TDR_TDAT_9BIT_LSHIFT)
> 
> I agree this is rather useless.

OK.

Cheers,
Biju