linux-kernel - RE: [PATCH v3 08/13] serial: sh-sci: Add sci_is_rsci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346A56EFFC3917372EB5E3C86D2A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sat, 22 Nov 2025 13:32:05 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, biju.das.au <biju.das.au@...il.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
	<jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, magnus.damm
	<magnus.damm@...il.com>, wsa+renesas <wsa+renesas@...g-engineering.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v3 08/13] serial: sh-sci: Add sci_is_rsci_type()

Hi Geert,

Thanks for the feedback,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 21 November 2025 15:17
> Subject: Re: [PATCH v3 08/13] serial: sh-sci: Add sci_is_rsci_type()
> 
> Hi Biju,
> 
> On Fri, 14 Nov 2025 at 11:52, Biju <biju.das.au@...il.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > Add sci_is_rsci_type() for RSCI port type. This will simplify the code
> > when the support added for RSCI_PORT_{SCI,SCIF} private PORT type.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -1182,6 +1182,11 @@ static int sci_handle_errors(struct uart_port *port)
> >         return copied;
> >  }
> >
> > +static bool sci_is_rsci_type(u8 type) {
> > +       return (type == SCI_PORT_RSCI || type == RSCI_PORT_SCI || type
> > +== RSCI_PORT_SCIF);
> 
> Would be much more consistent if all port types would use the
> RSCI_PORT_* prefix...

Agreed, Will update.

Cheers,
Biju