linux-kernel - Re: [PATCH V3 7/7] workqueue: Process extra works in rescuer when there are no more to rescue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSHJWTSxnN7SP9Vy@slm.duckdns.org>
Date: Sat, 22 Nov 2025 04:31:53 -1000
From: Tejun Heo <tj@...nel.org>
To: Lai Jiangshan <jiangshanlai@...il.com>
Cc: linux-kernel@...r.kernel.org, ying chen <yc1082463@...il.com>,
	Lai Jiangshan <jiangshan.ljs@...group.com>
Subject: Re: [PATCH V3 7/7] workqueue: Process extra works in rescuer when
 there are no more to rescue

Hello,

On Sat, Nov 22, 2025 at 03:07:25PM +0800, Lai Jiangshan wrote:
...
> But this patch does not really check if memory pressure is still on,
> using (pool->flags & POOL_MANAGER_ACTIVE) can kind of
> achieve it, though not precisely. There is never a precise way,
> but the system has poured some resources to create the rescuer,
> it is better to make the best use of it, like before patch 2/7.
> 
> this patch:
>        if (!pwq->nr_active)
>                 return false;
>        if (!need_to_create_worker(pool)) {
>                if (limited || !list_empty(&pwq->wq->maydays))
>                        return false;
>        }
> 
> with memory pressure test via POOL_MANAGER_ACTIVE:
> 
>        if (!pwq->nr_active)
>                 return false;
>        if (!need_to_create_worker(pool)) {
>                if (limited || !(pool->flags & POOL_MANAGER_ACTIVE) ||
> !list_empty(&pwq->wq->maydays))
>                        return false;
>        }
> 
> What do you think?

Yeah, POOL_MANAGER_ACTIVE seems like a more reliable condition to test.
Let's do that.

Thanks.

-- 
tejun