linux-kernel - Re: [PATCH] lib/crypto: blake2b: Limit frame size workaround to GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <90EF627D-97C7-4CE2-B5CD-80000567F361@linux.dev>
Date: Sun, 23 Nov 2025 00:23:02 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Eric Biggers <ebiggers@...nel.org>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
 Ard Biesheuvel <ardb@...nel.org>,
 linux-crypto@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/crypto: blake2b: Limit frame size workaround to GCC <
 12.2 on i386

On 22. Nov 2025, at 21:04, Eric Biggers wrote:
> On Sat, Nov 22, 2025 at 11:55:31AM +0100, Thorsten Blum wrote:
>> The GCC bug only occurred on i386 and has been resolved since GCC 12.2.
>> Limit the frame size workaround to GCC < 12.2 on i386.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
>> [...]
> 
> How about we do it without the nested ifeq?
> 
> ifeq ($(CONFIG_X86_32)$(CONFIG_CC_IS_GCC)_$(call gcc-min-version, 120200),yy_)
> CFLAGS_blake2b.o := -Wframe-larger-than=4096 #  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105930
> endif

I considered it and went with the nested ifeq, but I'm fine with both.

> Also, according to the bugreport this was a regression in gcc 12.  With
> it having been fixed in 12.2, i.e. within the same gcc release series,
> is this workaround still worth carrying at all?

Not sure - gcc 8.1.0 is still the min version supported by the kernel.

Thorsten