| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <df986ad5-5159-45e1-a236-0ff86c19eaa7@gmx.de>
Date: Sun, 23 Nov 2025 00:55:29 +0100
From: Armin Wolf <W_Armin@....de>
To: Werner Sembach <wse@...edocomputers.com>, hansg@...nel.org,
ilpo.jarvinen@...ux.intel.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] platform/x86/uniwill: Handle more WMI events
required for TUXEDO devices
Am 20.11.25 um 22:49 schrieb Werner Sembach:
> Handle more WMI events that are triggered on TUXEDO devices.
>
> Testing the TUXEDO InfinityBook Pro 15 Gen9 Intel, the Stellaris 16 Gen5
> Intel, the Stellaris 16 Gen5 AMD and going through the out of tree
> tuxedo-drivers dkms package I identified more WMI events that are used by
> Uniwill.
>
> This patch binds them to their respective function, or marks them as
> KE_IGNORE when they are send in addition to other actions, to make clear
> that they don't need special handling. This also avoids warnings in dmesg.
>
> The events with descriptions from memory:
>
> UNIWILL_OSD_RADIOON and UNIWILL_OSD_RADIOOFF - Sent in addition to the
> already handled UNIWILL_OSD_RFKILL on some devices.
>
> UNIWILL_OSD_PERFORMANCE_MODE_TOGGLE - Physical button on some devices. Bind
> it to a button so userspace can receive the keypress and to stuff with it.
>
> UNIWILL_OSD_MUTE - Sent in addition to an already handled keypress.
>
> UNIWILL_OSD_KB_LED_LEVEL0 - UNIWILL_OSD_KB_LED_LEVEL4 - Some devices sent
> these instead of UNIWILL_OSD_KBDILLUMTOGGLE.
>
> UNIWILL_OSD_WEBCAM_TOGGLE - Sent in addition to deactivating the Webcam on
> firmware level.
>
> UNIWILL_OSD_DC_ADAPTER_CHANGED - No special handling required here atm, but
> will be for the charging priority feature.
Reviewed-by: Armin Wolf <W_Armin@....de>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> ---
> drivers/platform/x86/uniwill/uniwill-acpi.c | 21 ++++++++++++++++++++-
> drivers/platform/x86/uniwill/uniwill-wmi.h | 2 ++
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
> index 014960d16211b..e0d356dfc74c7 100644
> --- a/drivers/platform/x86/uniwill/uniwill-acpi.c
> +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
> @@ -371,9 +371,11 @@ static const struct key_entry uniwill_keymap[] = {
>
> /* Reported in manual mode when toggling the airplane mode status */
> { KE_KEY, UNIWILL_OSD_RFKILL, { KEY_RFKILL }},
> + { KE_IGNORE, UNIWILL_OSD_RADIOON, { KEY_UNKNOWN }},
> + { KE_IGNORE, UNIWILL_OSD_RADIOOFF, { KEY_UNKNOWN }},
>
> /* Reported when user wants to cycle the platform profile */
> - { KE_IGNORE, UNIWILL_OSD_PERFORMANCE_MODE_TOGGLE, { KEY_UNKNOWN }},
> + { KE_KEY, UNIWILL_OSD_PERFORMANCE_MODE_TOGGLE, { KEY_F14 }},
>
> /* Reported when the user wants to adjust the brightness of the keyboard */
> { KE_KEY, UNIWILL_OSD_KBDILLUMDOWN, { KEY_KBDILLUMDOWN }},
> @@ -382,11 +384,19 @@ static const struct key_entry uniwill_keymap[] = {
> /* Reported when the user wants to toggle the microphone mute status */
> { KE_KEY, UNIWILL_OSD_MIC_MUTE, { KEY_MICMUTE }},
>
> + /* Reported when the user wants to toggle the mute status */
> + { KE_IGNORE, UNIWILL_OSD_MUTE, { KEY_MUTE }},
> +
> /* Reported when the user locks/unlocks the Fn key */
> { KE_IGNORE, UNIWILL_OSD_FN_LOCK, { KEY_FN_ESC }},
>
> /* Reported when the user wants to toggle the brightness of the keyboard */
> { KE_KEY, UNIWILL_OSD_KBDILLUMTOGGLE, { KEY_KBDILLUMTOGGLE }},
> + { KE_KEY, UNIWILL_OSD_KB_LED_LEVEL0, { KEY_KBDILLUMTOGGLE }},
> + { KE_KEY, UNIWILL_OSD_KB_LED_LEVEL1, { KEY_KBDILLUMTOGGLE }},
> + { KE_KEY, UNIWILL_OSD_KB_LED_LEVEL2, { KEY_KBDILLUMTOGGLE }},
> + { KE_KEY, UNIWILL_OSD_KB_LED_LEVEL3, { KEY_KBDILLUMTOGGLE }},
> + { KE_KEY, UNIWILL_OSD_KB_LED_LEVEL4, { KEY_KBDILLUMTOGGLE }},
>
> /* FIXME: find out the exact meaning of those events */
> { KE_IGNORE, UNIWILL_OSD_BAT_CHARGE_FULL_24_H, { KEY_UNKNOWN }},
> @@ -395,6 +405,9 @@ static const struct key_entry uniwill_keymap[] = {
> /* Reported when the user wants to toggle the benchmark mode status */
> { KE_IGNORE, UNIWILL_OSD_BENCHMARK_MODE_TOGGLE, { KEY_UNKNOWN }},
>
> + /* Reported when the user wants to toggle the webcam */
> + { KE_IGNORE, UNIWILL_OSD_WEBCAM_TOGGLE, { KEY_UNKNOWN }},
> +
> { KE_END }
> };
>
> @@ -1247,6 +1260,12 @@ static int uniwill_notifier_call(struct notifier_block *nb, unsigned long action
> }
> mutex_unlock(&data->battery_lock);
>
> + return NOTIFY_OK;
> + case UNIWILL_OSD_DC_ADAPTER_CHANGED:
> + /* noop for the time being, will change once charging priority
> + * gets implemented.
> + */
> +
> return NOTIFY_OK;
> default:
> mutex_lock(&data->input_lock);
> diff --git a/drivers/platform/x86/uniwill/uniwill-wmi.h b/drivers/platform/x86/uniwill/uniwill-wmi.h
> index 2bf69f2d80381..48783b2e9ffb9 100644
> --- a/drivers/platform/x86/uniwill/uniwill-wmi.h
> +++ b/drivers/platform/x86/uniwill/uniwill-wmi.h
> @@ -113,6 +113,8 @@
>
> #define UNIWILL_OSD_BENCHMARK_MODE_TOGGLE 0xC0
>
> +#define UNIWILL_OSD_WEBCAM_TOGGLE 0xCF
> +
> #define UNIWILL_OSD_KBD_BACKLIGHT_CHANGED 0xF0
>
> struct device;
Powered by blists - more mailing lists