linux-kernel - Re: [PATCH] crypto: starfive: Correctly handle return of sg_nents_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSEqaVkSZUgZ3iZD@gondor.apana.org.au>
Date: Sat, 22 Nov 2025 11:13:45 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: jiajie.ho@...rfivetech.com, william.qiu@...rfivetech.com,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: starfive: Correctly handle return of
 sg_nents_for_len

On Mon, Nov 10, 2025 at 02:54:38PM +0800, Haotian Zhang wrote:
> The return value of sg_nents_for_len was assigned to an unsigned long
> in starfive_hash_digest, causing negative error codes to be converted
> to large positive integers.
> 
> Add error checking for sg_nents_for_len and return immediately on
> failure to prevent potential buffer overflows.
> 
> Fixes: 7883d1b28a2b ("crypto: starfive - Add hash and HMAC support")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---
>  drivers/crypto/starfive/jh7110-hash.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt