linux-kernel - Re: [PATCH v2] r8169: add support for RTL8127ATF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN9vWDLGSDQQMPBVesOwAR3vvPko+ZG-eyxrL96OUM=1J05Ojg@mail.gmail.com>
Date: Sun, 23 Nov 2025 17:26:31 +0100
From: Michael Zimmermann <sigmaepsilon92@...il.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Fabio Baltieri <fabio.baltieri@...il.com>, nic_swsd@...ltek.com, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] r8169: add support for RTL8127ATF

> +       }, {
> +               PHY_ID_MATCH_EXACT(0x001ccbff),
> +               .name           = "Realtek SFP PHY Mode",
> +               .flags          = PHY_IS_INTERNAL,
> +               .probe          = rtl822x_probe,
> +               .get_features   = rtlgen_sfp_get_features,
> +               .config_aneg    = rtlgen_sfp_config_aneg,
> +               .read_status    = rtl822x_read_status,
> +               .suspend        = genphy_suspend,
> +               .resume         = rtlgen_resume,
> +               .read_page      = rtl821x_read_page,
> +               .write_page     = rtl821x_write_page,
> +               .read_mmd       = rtl822x_read_mmd,
> +               .write_mmd      = rtl822x_write_mmd,

I didn't get a chance to test your patch, yet, but is this intended to
match RTL8127AF? Because that's not it's phy id. It's the same as
RTL_8261C and currently matches "Realtek Internal NBASE-T PHY":

# cat /proc/self/net/r8127/enp8s0/debug/eth_phy

Dump Ethernet PHY

Offset  Value
------  -----

####################page 0##################

0x00:   0040 798d 001c c890 1c01 0000 0064 2001
0x08:   0000 0000 0000 0000 0000 0000 0000 2000
####################extra reg##################

0xa400: 0040 798d 001c c890 1c01 0000 0064 2001
0xa410: 0000 0000 0000
0xa434: 0a0c
0xa5d0: 0000 0000 0001 4000
0xa61a: 0400
0xa6d0: 0000 0000 0000