linux-kernel - Re: [PATCH v2 1/3] mfd: sprd-sc27xx: Integrate power off and reboot support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSNFk7tZqcgBqYsI@abscue.de>
Date: Sun, 23 Nov 2025 18:34:11 +0100
From: Otto Pflüger <otto.pflueger@...cue.de>
To: Lee Jones <lee@...nel.org>
Cc: Orson Zhai <orsonzhai@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>,
	Mark Brown <broonie@...nel.org>, Sebastian Reichel <sre@...nel.org>,
	Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/3] mfd: sprd-sc27xx: Integrate power off and reboot
 support

On Thu, Nov 20, 2025 at 03:30:24PM +0000, Lee Jones wrote:
> On Mon, 10 Nov 2025, Otto Pflüger wrote:
> 
> > The SC27xx PMICs allow restarting and powering off the device. Since
> > this functionality is rather simple and not configurable in any way,
> > make it part of the main PMIC driver.
> 
> This sounds like more of a drivers/power thing.

This was originally in drivers/power, but according to [1], it should
not be a separate device tree node. Using a separate driver without a
separate device tree node would still involve some code here that
instantiates a platform device and selects the right platform data for
it.

Registering the poweroff handler directly seemed less complex, and I
assumed it was okay since some other MFD drivers (e.g. rk8xx) also
implement the same functionality without a separate power driver.

Is it a good idea to use devm_mfd_add_devices here instead?

[1]: https://lore.kernel.org/all/20251002025344.GA2958334-robh@kernel.org/