linux-kernel - RE: [PATCH v2] mm/hugetlb: Fix incorrect error return from hugetlb_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <CH3PR12MB75487DC9A0A8596471A37B21ABD3A@CH3PR12MB7548.namprd12.prod.outlook.com>
Date: Sun, 23 Nov 2025 19:40:33 +0000
From: Shameer Kolothum <skolothumtho@...dia.com>
To: Joshua Hahn <joshua.hahnjy@...il.com>, "linux-mm@...ck.org"
	<linux-mm@...ck.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "muchun.song@...ux.dev" <muchun.song@...ux.dev>, "osalvador@...e.de"
	<osalvador@...e.de>, "vivek.kasireddy@...el.com" <vivek.kasireddy@...el.com>,
	Jason Gunthorpe <jgg@...dia.com>, Nicolin Chen <nicolinc@...dia.com>, Nathan
 Chen <nathanc@...dia.com>, Matt Ochs <mochs@...dia.com>
Subject: RE: [PATCH v2] mm/hugetlb: Fix incorrect error return from
 hugetlb_reserve_pages()

A gentle ping...It would be great if this can be picked up if there
are no further comments.

Thanks,
Shameer

> -----Original Message-----
> From: Joshua Hahn <joshua.hahnjy@...il.com>
> Sent: 24 October 2025 15:51
> To: Shameer Kolothum <skolothumtho@...dia.com>
> Cc: linux-mm@...ck.org; linux-kernel@...r.kernel.org;
> muchun.song@...ux.dev; osalvador@...e.de; vivek.kasireddy@...el.com;
> joshua.hahnjy@...il.com; Jason Gunthorpe <jgg@...dia.com>; Nicolin
> Chen <nicolinc@...dia.com>; Nathan Chen <nathanc@...dia.com>; Matt
> Ochs <mochs@...dia.com>
> Subject: Re: [PATCH v2] mm/hugetlb: Fix incorrect error return from
> hugetlb_reserve_pages()


> Reviewed-by: Joshua Hahn <joshua.hahnjy@...il.com>
> 
> [...snip...]
> 
> > +             /* region_chg() above can return -ENOMEM */
> > +             err = (chg == -ENOMEM) ? -ENOMEM : -EINVAL;
> 
> And this looks much more elegant than the version I wrote : -)