linux-kernel - Re: [PATCH] rust: i2c: prepare for `core::ffi::CStr`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DEGCU5OZP560.SWESWJ4G920F@kernel.org>
Date: Mon, 24 Nov 2025 09:25:44 +1300
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Miguel Ojeda" <ojeda@...nel.org>
Cc: "Igor Korotin" <igor.korotin.linux@...il.com>, "Stephen Rothwell"
 <sfr@...b.auug.org.au>, "Greg KH" <greg@...ah.com>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Daniel Almeida" <daniel.almeida@...labora.com>,
 <rust-for-linux@...r.kernel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 "Gary Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, <linux-kernel@...r.kernel.org>,
 <patches@...ts.linux.dev>
Subject: Re: [PATCH] rust: i2c: prepare for `core::ffi::CStr`

On Mon Nov 24, 2025 at 5:35 AM NZDT, Miguel Ojeda wrote:
> The rust-next tree contains commit:
>
>     3b83f5d5e78a ("rust: replace `CStr` with `core::ffi::CStr`")
>
> which, when merged together with commits:
>
>     57c5bd9aee94 ("rust: i2c: add basic I2C device and driver abstractions")
>     f3cc26a417b7 ("rust: i2c: add manual I2C device creation abstractions")
>
> from this tree (driver-core), produces errors like the following:
>
>     error[E0599]: no method named `len_with_nul` found for reference `&'static ffi::CStr` in the current scope
>       --> rust/kernel/i2c.rs:48:16
>        |
>     48 |             id.len_with_nul() <= Self::I2C_NAME_SIZE,
>        |                ^^^^^^^^^^^^ method not found in `&CStr`
>
>     error[E0599]: no method named `as_bytes_with_nul` found for reference `&'static ffi::CStr` in the current scope
>       --> rust/kernel/i2c.rs:51:22
>        |
>     51 |         let src = id.as_bytes_with_nul();
>        |                      ^^^^^^^^^^^^^^^^^
>        |
>     help: there is a method `to_bytes_with_nul` with a similar name
>        |
>     51 |         let src = id.to_bytes_with_nul();
>        |                      ~~~~~~~~~~~~~~~~~
>
> which were detected in linux-next by Stephen [1].
>
> The `i2c` code can be independently prepared to be ready for the change,
> thus do so.
>
> The change is similar to the one done by Tamir in commit 657403637f7d
> ("rust: acpi: use `core::ffi::CStr` method names").
>
> Link: https://lore.kernel.org/all/20251120181111.65ce75a0@canb.auug.org.au/ [1]
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Applied to driver-core-next, thanks!