linux-kernel - Re: [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca42bf49-47a7-40c5-9b39-1651feaa29b9@roeck-us.net>
Date: Sun, 23 Nov 2025 12:34:11 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Oleksandr Suvorov <cryosay@...il.com>, linux-kernel@...r.kernel.org
Cc: Fabio Estevam <festevam@...il.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option

On 11/23/25 12:24, Oleksandr Suvorov wrote:
> The module parameter `nowayout` indicates whether the watchdog should ever
> be allowed to stop, but the driver currently ignores this option.
> 
> Pass the `nowayout` parameter to the watchdog core by setting the
> WDOG_NO_WAY_OUT flag accordingly.
> 
> Signed-off-by: Oleksandr Suvorov <cryosay@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> 
> ---
> 
>   drivers/watchdog/imx7ulp_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c
> index 0f13a30533574..03479110453ce 100644
> --- a/drivers/watchdog/imx7ulp_wdt.c
> +++ b/drivers/watchdog/imx7ulp_wdt.c
> @@ -346,6 +346,7 @@ static int imx7ulp_wdt_probe(struct platform_device *pdev)
>   	watchdog_stop_on_reboot(wdog);
>   	watchdog_stop_on_unregister(wdog);
>   	watchdog_set_drvdata(wdog, imx7ulp_wdt);
> +	watchdog_set_nowayout(wdog, nowayout);
>   
>   	imx7ulp_wdt->hw = of_device_get_match_data(dev);
>   	ret = imx7ulp_wdt_init(imx7ulp_wdt, wdog->timeout * imx7ulp_wdt->hw->wdog_clock_rate);