linux-kernel - Re: [PATCH] nvmem: apple-spmi-nvmem: wrap regmap calls to satisfy CFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d0aa1ef-a356-4ce0-8ea4-321d07c25ad2@kernel.org>
Date: Sun, 23 Nov 2025 22:46:06 +0100
From: Sven Peter <sven@...nel.org>
To: Jens Reidel <adrian@...nlining.org>, Janne Grunau <j@...nau.net>,
 Neal Gompa <neal@...pa.dev>, Srinivas Kandagatla <srini@...nel.org>,
 Sasha Finkelstein <fnkl.kernel@...il.com>, Hector Martin <marcan@...can.st>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Clayton Craft <craftyguy@...tmarketos.org>,
 stable@...r.kernel.org
Subject: Re: [PATCH] nvmem: apple-spmi-nvmem: wrap regmap calls to satisfy CFI

On 18.11.25 03:35, Jens Reidel wrote:
> The Apple SPMI NVMEM driver previously cast regmap_bulk_read/write to
> void * when assigning them to nvmem_config's reg_read/reg_write
> function pointers.
> 
> This cast breaks the expected function signature of nvmem_reg_read_t
> and nvmem_reg_write_t. With CFI enabled, indirect calls through
> these pointers fail:
> 
>    CFI failure at nvmem_reg_write+0x194/0x1e4 (target: regmap_bulk_write+0x0/0x2c8; expected type: 0x83a189c3)
>    ...
>    Call trace:
>     nvmem_reg_write+0x194/0x1e4 (P)
>     __nvmem_cell_entry_write+0x298/0x2e8
>     nvmem_cell_write+0x24/0x34
>     macsmc_reboot_probe+0x1dc/0x454 [macsmc_reboot]
>    ...
> 
> Introduce thin wrapper functions with the correct nvmem function
> pointer types to satisfy the CFI checks.
> 
> Fixes: fe91c24a551c ("nvmem: Add apple-spmi-nvmem driver")
> Signed-off-by: Jens Reidel <adrian@...nlining.org>
> Reported-by: Clayton Craft <craftyguy@...tmarketos.org>
> Tested-by: Clayton Craft <craftyguy@...tmarketos.org>
> Cc: stable@...r.kernel.org
> ---

Reviewed-by: Sven Peter <sven@...nel.org>


Thanks,


Sven