linux-kernel - Re: [PATCH v1 1/1] lib/vsprintf: Unify FORMAT_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSR0-UkIlZkMhLG0@pathway.suse.cz>
Date: Mon, 24 Nov 2025 16:08:41 +0100
From: Petr Mladek <pmladek@...e.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1 1/1] lib/vsprintf: Unify FORMAT_STATE_NUM handlers

On Thu 2025-11-20 09:31:40, Andy Shevchenko wrote:
> We have two almost identical pieces that handle FORMAT_STATE_NUM case.
> The differences are:
> - redundant {} for one-line if-else conditional
> - missing blank line after variable definitions
> - inverted conditional
> 
> Unify the style of two.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@...e.com>

It is a trivial change. I am going to push it right away...

Best Regards,
Petr